Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
masonry: reimplement
Widget::get_child_at_pos
#565base: main
Are you sure you want to change the base?
masonry: reimplement
Widget::get_child_at_pos
#565Changes from 10 commits
098c0bf
ee01ea8
b77bb9f
a17447b
cb2dcaa
79348ac
f0eb0fc
499242c
6f88715
7aebe37
8c8aa7d
1eac8bc
f7589ee
719d9ce
0b5528d
cfe929e
9591a3c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should implementations overriding the default uphold certain conditions?
Custom implementations should probably uphold the guarantee that
pos
is actually inside the returned child's layout rect. Must custom custom implementations also uphold the guarantee thatpos
is contained in the clip path, and that in case of overlap the last child in "z-order" is chosen?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes to all of these.
Ideally we should even implement some best-effort checks in debug_assertions mode to enforce that these conditions are upheld.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The low effort version is to check the child contains the position in its layout rect and clip path.
The conditions uniquely identify a child, so we could do the default search alongside
Widget::get_child_at_pos
and check the same children are returned. For widgets with many children—where custom implementations are most likely—this would be slow. Valid options are to accept that cost or to limit this exhaustive check to widgets with N children for some value of N.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, most of that is beyond the scope of this PR.
We could probably add a TODO comment and keep it to that for now.
Sure. I was thinking we'd probably need to add a
child_count()
method for cases where building a child array is needlessly expensive (eg a Flex with thousands of children).