Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: initial changelog #3

Merged
merged 6 commits into from
Mar 22, 2024
Merged

docs: initial changelog #3

merged 6 commits into from
Mar 22, 2024

Conversation

simbleau
Copy link
Member

Adds an initial changelog

DJMcNab
DJMcNab reviewed Mar 22, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits to address, but otherwise this looks like a good start

Bringing in @xStrom for awareness, as IIRC they have mentioned having opinions on/plans for changelogs

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
DJMcNab
DJMcNab approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog looks good.

Not sure what the doc changes are for

src/lib.rs Outdated Show resolved Hide resolved
@simbleau
Copy link
Member Author

Changelog looks good.

Not sure what the doc changes are for

Just wanted to squeeze it in.

@simbleau simbleau merged commit 3674f6e into main Mar 22, 2024
9 checks passed
@DJMcNab DJMcNab deleted the changelog branch March 22, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simbleau @DJMcNab