Support bitmap fonts #641
Support bitmap fonts #641
Conversation
There was a problem hiding this comment.
I don't think there is any license issue here. Our licenses match exactly, and we already have Google LLC code in the repo as-is.
I think our generic LICENSE-MIT is sufficient. We can also add Colin Rothfels to our AUTHORS file, even though that doesn't have an impact on copyright.
Thus I think we should just keep it simple, use our standard copyright header, not modify the copyright check, not add LICENSE-MIT-SKRIFA, and not worry about making changes to the bitmap.rs file.
| @@ -511,7 +511,8 @@ impl<'a> DrawGlyphs<'a> { | |||
|
|
|||
| if !mask.is_packed { | |||
| // TODO: Error once? | |||
| log::warn!("Unpacked mask data not handled"); | |||
| log::warn!("Unpacked mask data in font not yet supported"); | |||
| // TODO: How do we get the font name here? | |||
There was a problem hiding this comment.
If we were using tracing, we'd be able to have some context data around that made this more clear, perhaps? (Clearly not a thing for this PR to solve.)
There was a problem hiding this comment.
I suspect that getting that information "just-in-case" all the time would be too expensive. This is a potentially hot-spot in the API.
There was a problem hiding this comment.
Ideally, it would be somewhere further up the call stack, although for fonts, maybe not quite far enough.
DJMcNab
force-pushed
the
fontmap
branch
2 times, most recently
from
6a9c135
to
337d044
Compare
All the relevant code was written by Chad Co-authored-by: Kaur Kuut <[email protected]>
Resolve bitmap Emoji fonts at scene construction time (rather than the ideal resolve time for glyph caching) for expedience.
Current status: Layout details aren't entirely correct