Migrate to our Standard CI #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| - name: cargo clippy (wasm) | ||
| run: cargo clippy --all-targets --target wasm32-unknown-unknown -- -D warnings | ||
| env: |
There was a problem hiding this comment.
This is an improvement!
DJMcNab
commented
Feb 14, 2024
Comment on lines
+23
to
+26
| // TODO: This is a public method, which means it definitely is not | ||
| // "dead code". However, rustc seems insitent that it is, and so to not | ||
| // block forward progress, I shall humour it | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
I can't prioritise debugging and resolving this, so think we should land this without that
There was a problem hiding this comment.
Yeah I honestly think it's a bug in Rust, the error warning doesn't make sense to me as the type BindType is clearly public...
Philipp-M
approved these changes
Feb 14, 2024
Comment on lines
+23
to
+26
| // TODO: This is a public method, which means it definitely is not | ||
| // "dead code". However, rustc seems insitent that it is, and so to not | ||
| // block forward progress, I shall humour it | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
Yeah I honestly think it's a bug in Rust, the error warning doesn't make sense to me as the type BindType is clearly public...
simbleau
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Headless: Pass in the use_cpu arugment * Move to our standard CI * "Resolve" the warnings detected by CI * Fix the doc warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also linebender/peniko#21
I haven't added an MSRV yet, as we're not at that stage
This also lets the headless example use the
--use-cpuflag. This isn't currently used in CI - I'm planning to make atestscrate/PR instead