Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: with_winit: Update notify-debouncer-mini and console-log. #344

Merged
merged 1 commit into from
Jul 27, 2023
Merged

deps: with_winit: Update notify-debouncer-mini and console-log. #344

merged 1 commit into from
Jul 27, 2023

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

DJMcNab
DJMcNab reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hot reloading still works, although I haven't tested the console logging.

It still compiles though, so it seems reasonable

DJMcNab
DJMcNab approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve this - our web integration is best effort anyway, so I'm happy to merge without testing the changes there

@waywardmonkeys waywardmonkeys merged commit 4a7d328 into linebender:main Jul 27, 2023
4 checks passed
@waywardmonkeys waywardmonkeys deleted the update-with_winit-deps branch July 27, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

@xStrom xStrom Awaiting requested review from xStrom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waywardmonkeys @DJMcNab