Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update references to piet-gpu where it makes sense #240

Merged
merged 5 commits into from
Jan 8, 2023
Merged

Update references to piet-gpu where it makes sense #240

merged 5 commits into from
Jan 8, 2023

Conversation

canadaduane
Copy link
Contributor

  • Update "piet-gpu authors" to "vello authors"
  • Update comments
  • Update example text: "hello piet-gpu text" => "hello vello text"
  • Preserve vision.md but add explanation to connect "vello" to "piet-gpu"

raphlinus
raphlinus reviewed Jan 7, 2023
View reviewed changes
doc/shader_compilation.md Outdated Show resolved Hide resolved
raphlinus
raphlinus reviewed Jan 7, 2023
View reviewed changes
shader/fine.wgsl Outdated Show resolved Hide resolved
DJMcNab
DJMcNab approved these changes Jan 8, 2023
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; I've been meaning to do this! A few thoughts where details have been lost here.

Cargo.toml Outdated Show resolved Hide resolved
doc/shader_compilation.md Outdated Show resolved Hide resolved
shader/fine.wgsl Outdated Show resolved Hide resolved
shader/shared/config.wgsl Outdated Show resolved Hide resolved
shader/tile_alloc.wgsl Outdated Show resolved Hide resolved
src/engine.rs Outdated Show resolved Hide resolved
examples/with_winit/src/simple_text.rs Show resolved Hide resolved
@canadaduane
Copy link
Contributor Author

BTW I love "hello vello". Reminds me of "mellow yellow" https://www.youtube.com/watch?v=IQNBQI3UDag

DJMcNab
DJMcNab approved these changes Jan 8, 2023
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! Just a couple missed details

Removing the other authors isn't critical

src/engine.rs Outdated Show resolved Hide resolved
Cargo.toml
@@ -6,7 +6,6 @@ members = ["examples/with_winit", "examples/with_bevy", "examples/run_wasm"]
[workspace.package]
edition = "2021"
version = "0.1.0"
authors = ["piet-gpu developers"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are authors also set elsewhere, which should probably also be removed

That is at least further down this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I removed the authors key in the [package] section, which is I think what you mean.

@DJMcNab
Copy link
Member

DJMcNab commented Jan 8, 2023

@raphlinus just want to get your thoughts/assent on removing the authors. Reasoning is in #240 (comment).

Once we have that, I'll do final cleanup and merge.

@raphlinus
Copy link
Contributor

Yup if the RFC says it's not useful, fine with me. I don't believe it's needed. Thanks both of you for refining this!

@DJMcNab DJMcNab merged commit 3e8a481 into linebender:main Jan 8, 2023
@DJMcNab
Copy link
Member

DJMcNab commented Jan 8, 2023

Thanks for this!

@canadaduane canadaduane deleted the rename-vello branch January 8, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphlinus raphlinus raphlinus left review comments

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@canadaduane @DJMcNab @raphlinus