Skip to content

Commit

Permalink
Remove download command, keep download directory. (#586)
Browse files Browse the repository at this point in the history
This still allows loading from the download directory, but removes the
command that would download to it, allowing people to populate it
themselves.

The files downloaded were parsed with the `vello_svg` parser, but that
was removed from here and moved to its own home, so files loaded would
need some preprocessing (to be defined elsewhere).
  • Loading branch information
waywardmonkeys committed May 26, 2024
1 parent ba855c5 commit c70bbc3
Show file tree
Hide file tree
Showing 9 changed files with 28 additions and 705 deletions.
288 changes: 1 addition & 287 deletions Cargo.lock

Large diffs are not rendered by default.

7 changes: 0 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,13 +142,6 @@ It also includes a collection of test scenes showing the capabilities of `vello`
cargo run -p with_winit
```

Some default test scenes can be downloaded from Wikimedia Commons using the `download` subcommand.
This also supports downloading from user-provided URLS.

```shell
cargo run -p with_winit -- download
```

<!-- ### Headless -->

### Bevy
Expand Down
4 changes: 2 additions & 2 deletions examples/headless/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use std::num::NonZeroUsize;
use std::path::{Path, PathBuf};

use anyhow::{anyhow, bail, Context, Result};
use clap::{CommandFactory, Parser};
use clap::Parser;
use scenes::{ImageCache, SceneParams, SceneSet, SimpleText};
use vello::kurbo::{Affine, Vec2};
use vello::util::RenderContext;
Expand All @@ -20,7 +20,7 @@ fn main() -> Result<()> {
#[cfg(not(target_arch = "wasm32"))]
env_logger::init();
let args = Args::parse();
let scenes = args.args.select_scene_set(Args::command)?;
let scenes = args.args.select_scene_set()?;
if let Some(scenes) = scenes {
let mut scene_idx = None;
for (idx, scene) in scenes.scenes.iter().enumerate() {
Expand Down
6 changes: 0 additions & 6 deletions examples/scenes/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,5 @@ instant = { workspace = true }
# for pico_svg
roxmltree = "0.19.0"

# Used for the `download` command
[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
byte-unit = "4.0.19"
inquire = "0.7.5"
ureq = "2.9.7"

[target.'cfg(target_arch = "wasm32")'.dependencies]
getrandom = { version = "0.2.15", features = ["js"] }
214 changes: 0 additions & 214 deletions examples/scenes/src/download.rs

This file was deleted.

106 changes: 0 additions & 106 deletions examples/scenes/src/download/default_downloads.rs

This file was deleted.

Loading

0 comments on commit c70bbc3

Please sign in to comment.