Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vello_editor: Stop blinking and hide cursor when window not focused. #172

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

xorgy
Copy link
Member

@xorgy xorgy commented Nov 11, 2024

No description provided.

@xorgy xorgy changed the title Stop blinking cursor when window is not focused. vello_editor: Stop blinking cursor when window is not focused. Nov 11, 2024
@xorgy xorgy requested review from DJMcNab, nicoburns and waywardmonkeys and removed request for nicoburns and DJMcNab November 11, 2024 18:14
@mwcampbell
Copy link
Contributor

I believe the norm is for the cursor to disappear when the window loses focus, not become permanently shown.

@xorgy
Copy link
Member Author

xorgy commented Nov 11, 2024

You're right, or in the case of overwrite/block cursors it usually becomes an empty square. I'm more used to block cursors so I missed this.

@xorgy xorgy changed the title vello_editor: Stop blinking cursor when window is not focused. vello_editor: Stop blinking and hide cursor when window not focused. Nov 11, 2024
Copy link
Contributor

@mwcampbell mwcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xorgy xorgy added this pull request to the merge queue Nov 11, 2024
Merged via the queue into linebender:main with commit 737ab31 Nov 11, 2024
20 checks passed
@xorgy xorgy deleted the blink-when-focused branch November 11, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants