-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upconvert UFO v1 and v2 kerning data #32
Conversation
ufoLib fails itself when you up/downconvert UFOs from v2 -> v3 -> v2 and load the last UFO again. Since it leaves all groups intact, upconversion will hit duplicate group names and make new ones with the same glyph list. Validation will subsequently fail.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay a couple little nitty things but overall this looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay a couple little things you can try if you like, otherwise I'm happy!
7a4685f
to
f39a540
Compare
Also, make Groups a mapping of Strings to Vecs of GlyphNames (Arc<str>).
- Upgrade loaded UFO's meta version to v3 - Add GroupsUpconversionError, shares inner error with GroupsError
f39a540
to
93a5e4c
Compare
Part of #31.
TODO:
Tests/ufoLib/UFOConversion_test.py
!)What if the target kerning group exists already? Making the names unique won't save you from then potentially having glyphs in more than one kerning group. The reference implementation already fails here.Error outWhat if either groups.plist or kerning.plist exist but not both?The algorithm needs groups.plist at minimum, kerning.plist can be empty. Pass in empty container if kerning isNone
.