Create windows on mac #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a subset of the window creation API. At this point, it compiles and runs the examples in druid-shell, but with much functionality stubbed out, and no attempt to run the higher level. Uploading this as a checkpoint.
A few small things were broken.
rylev
reviewed
Feb 17, 2019
| @@ -26,9 +26,12 @@ use time::get_time; | |||
| use kurbo::{Line, Rect}; | |||
| use piet::{FillRule, FontBuilder, RenderContext, Text, TextLayoutBuilder}; | |||
|
|
|||
| #[cfg(target_os = "windows")] | |||
| use druid_shell::platform::PresentStrategy; | |||
There was a problem hiding this comment.
Q: What is PresentStrategy?
There was a problem hiding this comment.
See xi-editor/xi-win#17 . It's part of my quest to make window resizing smooth on Windows. It's not something that's meaningful on other platforms, and most actual users will use the default. It's exposed for experimentation.
rylev
reviewed
Feb 17, 2019
| /// This is an NSView, as our concept of "window" is more the top-level container holding | ||
| /// a view. Also, this is better for hosted applications such as VST. | ||
| /// | ||
| /// TODO: remove option (issue has been filed against objc, or we could manually impl default with nil) |
There was a problem hiding this comment.
Can you link the issue number?
|
FWIW, I have an implementation of IdleHandler and anim (the latter is crude, based on continual invalidation, rather than CVDisplayLink, but is ok to get this into a working state) in my local repo. I can add to this PR or file a new one. |
|
This looks good. Might be worth getting this in before adding the other stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a subset of the window creation API. At this point, it
compiles and runs the examples in druid-shell, but with much
functionality stubbed out, and no attempt to run the higher level.
Uploading this as a checkpoint.