Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove ZFunction #64

Merged
merged 1 commit into from
Jul 20, 2024
Merged

refactor: remove ZFunction #64

merged 1 commit into from
Jul 20, 2024

Conversation

simbleau
Copy link
Member

@simbleau simbleau commented Jul 20, 2024

Removes ZFunction from the render pipeline completely.

Z Functions were an artifact of my needs at a time before bevy_vello was merged into Linebender. They are an opinionated component that will calculate a new Z-index used for rendering for the user, with one of many functions that would make sense for 2.5D games, 2D platformers, etc.

Ultimately there's nothing special about Z Functions, they are just a convenience that can easily exist outside of the rendering pipeline using a system that changes the Z-value for an asset's transform on Update, which is why I'm removing them.

This will help to heighten maintainability by reducing quite a bit of code, and be less confusing for users who would've encountered these.

@simbleau simbleau changed the title refactor: remove z-ordering refactor: remove ZFunction Jul 20, 2024
@simbleau simbleau requested a review from seabassjh July 20, 2024 14:11
Copy link
Collaborator

@seabassjh seabassjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@simbleau simbleau added this pull request to the merge queue Jul 20, 2024
Merged via the queue into main with commit 5d900d7 Jul 20, 2024
6 checks passed
@simbleau simbleau deleted the remove-z-functions branch July 20, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants