Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not wrap an Arc in another Arc in VelloFont #62

Closed
wants to merge 1 commit into from
Closed

Do not wrap an Arc in another Arc in VelloFont #62

wants to merge 1 commit into from

Conversation

BD103
Copy link
Contributor

@BD103 BD103 commented Jul 5, 2024

Closes #60.

There was a bit of confusion with what I originally meant in that issue, so I hope this small PR shows what I intended.

@BD103 BD103 mentioned this pull request Jul 5, 2024
Copy link
Member

@simbleau simbleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: remove redundant Arc in VelloFont

@simbleau
Copy link
Member

simbleau commented Jul 5, 2024

Thank you!

@simbleau
Copy link
Member

simbleau commented Jul 5, 2024

Hmm, CI seems to be failing suddenly. Weird - I'll piggyback this change into #61 with co-author by you.

@simbleau simbleau closed this Jul 5, 2024
@BD103 BD103 deleted the unwrap-font-arc branch July 5, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VelloFont is Arc<Arc<[u8]>>
2 participants