Fix render matrix for VelloScene
s in Bevy UI nodes
#59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple issues I had when trying to use a
VelloScene
with Bevy's UI:top
orbottom
value on theStyle
component caused theVelloScene
to move in the opposite direction from the nodeThat said, I know there are different conventions for whether the Y-origin is top or bottom, and I'm honestly not sure where Vello's origin is under normal circumstances. Let me know if you'd like to preserve a bottom-left origin for Vello drawing commands while still positioning the Vello scene so that it aligns with the Bevy node — it shouldn't be overly difficult to make that adjustment.
I haven't tested this super exhaustively, but I did verify that the original "scene" example still works as expected, and added a new "scene-ui" example for testing the changes made here. Let me know if you have any questions, concerns, or would like to see any changes!