Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bevy asset meta data check #17

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

pengiie
Copy link
Contributor

@pengiie pengiie commented Dec 20, 2023

Due to this error/related issue on wasm builds with the new bevy assetv2 pipeline, the recommended solution was to disable asset meta data checks.

@simbleau
Copy link
Member

This is definitely a step closer, since thankfully it compiles!
However I'm not seeing the squid, weirdly enough.
image

There's also some validation warnings I'm seeing, almost certainly the case for why we don't see the squid:

127.0.0.1/:1 Tint WGSL reader failure: :780:40 error: value -1 cannot be represented as 'u32'
                    let delta = select(u32(-1), 1u, is_down) << ((delta_pix & 3u) << 3u);
                                       ^^^^^^^


 - While validating [ShaderModuleDescriptor "fine_msaa16"]
 - While calling [Device].CreateShaderModule([ShaderModuleDescriptor "fine_msaa16"]).

127.0.0.1/:1 1 error(s) generated while compiling the shader:
:780:40 error: value -1 cannot be represented as 'u32'
                    let delta = select(u32(-1), 1u, is_down) << ((delta_pix & 3u) << 3u);
                                       ^^^^^^^

127.0.0.1/:1 [Invalid ShaderModule "fine_msaa16"] is invalid.
 - While validating compute stage ([Invalid ShaderModule "fine_msaa16"], entryPoint: main).
 - While calling [Device].CreateComputePipeline([ComputePipelineDescriptor "fine_msaa16"]).

demo-72aa4d43f3099d1ceabd15af0fd97de11e45775835e0dba2c345a584ce8bf11dfadacf47b6dcb04bf8222bab467ea90d.js:432 INFO src/assets/asset_loader.rs:89 finished parsing json asset path = "../assets/squid.json";size = "(1024.0, 1024.0)";
249[Invalid ComputePipeline "fine_msaa16"] is invalid.
 - While encoding [ComputePassEncoder].SetPipeline([Invalid ComputePipeline "fine_msaa16"]).

249[Invalid CommandBuffer "render_to_texture" from CommandEncoder "render_to_texture"] is invalid.
 - While calling [Queue].Submit([[Invalid CommandBuffer "render_to_texture" from CommandEncoder "render_to_texture"]])

127.0.0.1/:1 WebGPU: too many warnings, no more warnings will be reported to the console for this GPUDevice.

@seabassjh Any thoughts?

@simbleau
Copy link
Member

simbleau commented Dec 20, 2023

Aha, this was a misconfigured AA setting. Sending some patch code now...

4510e0d

image

@simbleau simbleau merged commit 0097b1f into linebender:main Dec 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants