Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New bugs 2 #8

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

New bugs 2 #8

wants to merge 11 commits into from

Conversation

PavelLinearB
Copy link
Member

workerB

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
passed Passed Infrastructure as Code high 0  medium 0  low 0  info 0
passed Passed Vulnerabilities high 0  medium 0  low 0  info 0
passed Passed Secrets high 0  medium 0  low 0  info 0

Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 3 important findings in this PR that you should review.
The findings are detailed below as separate comments.
It’s highly recommended that you fix these security issues before merge.

val=""
val=login.objects.raw(sql_query)
val=login.objects.raw(sql_query)
val=login.objects.raw(sql_query)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Static Code Analysis Python Semgrep

Type: Gitlab.Bandit.B611

Description: You should be very careful whenever you write raw SQL. Consider using Django ORM before raw SQL. See https://docs.djangoproject.com/en/3.0/topics/db/sql/#passing-parameters-into-raw

Severity: HIGH

Learn more about this issue


Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_fp Ignore and mark this specific single instance of finding as “False Positive”
  • #jit_ignore_accept Ignore and mark this specific single instance of finding as “Accept Risk”
  • #jit_undo_ignore Undo ignore command

@@ -156,7 +156,9 @@
print(sql_query)
try:
print("\nin try\n")
val=""
val=login.objects.raw(sql_query)
val=login.objects.raw(sql_query)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Static Code Analysis Python Semgrep

Type: Gitlab.Bandit.B611

Description: You should be very careful whenever you write raw SQL. Consider using Django ORM before raw SQL. See https://docs.djangoproject.com/en/3.0/topics/db/sql/#passing-parameters-into-raw

Severity: HIGH

Learn more about this issue


Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_fp Ignore and mark this specific single instance of finding as “False Positive”
  • #jit_ignore_accept Ignore and mark this specific single instance of finding as “Accept Risk”
  • #jit_undo_ignore Undo ignore command

@@ -156,7 +156,9 @@
print(sql_query)
try:
print("\nin try\n")
val=""
val=login.objects.raw(sql_query)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Static Code Analysis Python Semgrep

Type: Gitlab.Bandit.B611

Description: You should be very careful whenever you write raw SQL. Consider using Django ORM before raw SQL. See https://docs.djangoproject.com/en/3.0/topics/db/sql/#passing-parameters-into-raw

Severity: HIGH

Learn more about this issue


Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_fp Ignore and mark this specific single instance of finding as “False Positive”
  • #jit_ignore_accept Ignore and mark this specific single instance of finding as “Accept Risk”
  • #jit_undo_ignore Undo ignore command

introduction/views.py Fixed Show fixed Hide fixed
introduction/views.py Fixed Show fixed Hide fixed
introduction/mitre.py Fixed Show fixed Hide fixed
@linear-b linear-b deleted a comment from gitstream-cm bot Jun 6, 2023
@linear-b linear-b deleted a comment from gitstream-cm bot Jun 6, 2023
@linear-b linear-b deleted a comment from gitstream-cm bot Jun 6, 2023
@linear-b linear-b deleted a comment from gitstream-cm bot Jun 6, 2023
@gitstream-cm gitstream-cm bot removed the Fix pending label Jun 6, 2023
@linear-b linear-b deleted a comment from gitstream-cm bot Jun 6, 2023
@linear-b linear-b deleted a comment from gitstream-cm bot Jun 6, 2023
@gitstream-cm
Copy link

gitstream-cm bot commented Jun 6, 2023

This PR failed due to High severity vulnerability finding, if you don't fix it please select:

  • I need help with that fix.
  • I want to accept the risk, please approve.
  • This is false positive, please approve.
  • This is a test / simulator environment, please exclude.

@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 6 Bugs
Vulnerability E 3 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gitstream-cm gitstream-cm bot removed the Fix pending label Jun 6, 2023
Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

Copy link

sonarcloud bot commented Dec 28, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

1 Security Hotspot
E Security Rating on New Code (required ≥ A)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@@ -210,6 +210,11 @@
# @authentication_decorator
@csrf_exempt
def mitre_lab_25_api(request):
if request.method == "POST":
expression = request.POST.get('expression')
result = eval(expression)

Check failure

Code scanning / SonarCloud

Dynamic code execution should not be vulnerable to injection attacks High

Change this code to not dynamically execute code influenced by user-controlled data. See more on SonarCloud
Copy link

gitstream-cm bot commented Dec 28, 2023

This PR failed due to High severity vulnerability finding, if you don't fix it please select:

  • I need help with that fix.
  • I want to accept the risk, please approve.
  • This is false positive, please approve.
  • This is a test / simulator environment, please exclude.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant