Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

topic:mirror-generator-modernize #81

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

topic:mirror-generator-modernize #81

wants to merge 5 commits into from

Commits on May 28, 2024

  1. gen_mirror_json: fix PEP8 errors 

    - Import `re`
- No bare `except`
- Space before colon in lambda

Signed-off-by: Han Sol Jin <[email protected]>
    @lifehackerhansol
    lifehackerhansol committed May 28, 2024
    Configuration menu
    Copy the full SHA
    f7fdfaf View commit details
    Browse the repository at this point in the history

  2. gen_mirror_json: switch to python3 

    Signed-off-by: Han Sol Jin <[email protected]>
    @lifehackerhansol
    lifehackerhansol committed May 28, 2024
    Configuration menu
    Copy the full SHA
    53f50e8 View commit details
    Browse the repository at this point in the history

  3. gen_mirror_json: fix ZipFile arguments 

    - `filepath` and `filename` are the same thing, just use `filename`
- `BASE_PATH` and `FILE_BASE` are the same thing, just use `BASE_PATH`
- Account for possibility that `BASE_PATH` may not have a trailing
  slash

Signed-off-by: Han Sol Jin <[email protected]>
    @lifehackerhansol
    lifehackerhansol committed May 28, 2024
    Configuration menu
    Copy the full SHA
    49fb589 View commit details
    Browse the repository at this point in the history

  4. Add parsing metadata from OTA package 

    Since Oreo, there is no `system/build.prop`, it is packaged into
`system.new.dat`. So timestamp generation hasn't worked for years now.

The OTA metadata on the other hand stores this timestamp (called
`post-timestamp`), so let's parse that instead.
    @lifehackerhansol
    pourekrami authored and lifehackerhansol committed May 28, 2024
    Configuration menu
    Copy the full SHA
    023b318 View commit details
    Browse the repository at this point in the history

  5. gen_mirror_json: explicitly specify we are reading in binary mode for… 

    … builds

Signed-off-by: Han Sol Jin <[email protected]>
    @lifehackerhansol
    lifehackerhansol committed May 28, 2024
    Configuration menu
    Copy the full SHA
    924db5b View commit details
    Browse the repository at this point in the history