Add HTTP-to-CD mirroring #821
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: It would be very useful to set up a simple mirror that mirrors the result of an HTTP query into a repository, just like IFTTT. Modifications: - Added support for the following two new URL schemes: - `http` - `https` - Renamed `Mirror.remotePath` to `remoteSubpath` to better reflect what it actually does. - Made `Mirror.remoteSubpath` nullable because HTTP-to-CD mirror doesn't need it. - Added `HttpMirror` and `HttpMirrorTest`. Result: - A user can mirror a certain HTTP endpoint into a file in Central Dogma. - Closes line#154 Future works: - Add support for basic and token-based authentication - Add documentation
minwoox
reviewed
Mar 14, 2023
| executor.execute(Command.push( | ||
| MIRROR_AUTHOR, localRepo().parent().name(), localRepo().name(), | ||
| Revision.HEAD, summary, "", Markup.PLAINTEXT, | ||
| Change.ofTextUpsert(localPath(), content))).join(); |
There was a problem hiding this comment.
How about raising an exception before creating HttpMirror if localPath is a directory?
juchanei
reviewed
Sep 14, 2023
| public static final String SCHEME_HTTP = "http"; | ||
|
|
||
| /** | ||
| * {@code "http"}. |
There was a problem hiding this comment.
I think this annotation has a typo!
Suggested change
| * {@code "http"}. | |
| * {@code "https"}. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It would be very useful to set up a simple mirror that mirrors the
result of an HTTP query into a repository, just like IFTTT.
Modifications:
httphttpsMirror.remotePathtoremoteSubpathto better reflect whatit actually does.
Mirror.remoteSubpathnullable because HTTP-to-CD mirror doesn'tneed it.
HttpMirrorandHttpMirrorTest.Result:
Future works: