Add ManagementService
#1034
Merged
Add ManagementService
#1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
Central Dogma does not provide a way to dump threads or heap data.
Modifications:
- Add `ManagementConfig` to config a management service using
`dogma.json` and `CentralDogmaBuilder`
- Register `ManagementService` based on the options specified in
`ManagementService`
Example:
- Serve a management service at the same ports of the main server
```
{
"management": {
"port": 0
}
}
```
- Serve a management service only at an internal port which won't be
exposed externally.
```
{
"management": {
"address": "127.0.0.1"
"port": 36463
}
}
```
Result:
You can now configure a managemet service to dump the thread information
or heap data.
minwoox
approved these changes
Sep 10, 2024
server/src/main/java/com/linecorp/centraldogma/server/ManagementConfig.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Central Dogma does not provide a way to dump threads or heap data.
Modifications:
ManagementConfigto config a management service usingdogma.jsonandCentralDogmaBuilderManagementServicebased on the options specified inManagementServiceExample:
{ "management": { "port": 0 } }{ "management": { "address": "127.0.0.1" "port": 36463 } }Result:
You can now configure a managemet service to dump the thread information or heap data.