TW-616 List all image & video of Chat in Chat details #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drminh2807
requested review from
sherlockvn,
hoangdat,
dab246,
nqhhdev and
imGok
as code owners
drminh2807
force-pushed
the
TW-616-List-all-image-video-of-Chat-in-Chat-details
branch
from
cf55859
to
808ba61
Compare
|
This PR has been deployed to https://linagora.github.io/twake-on-matrix/650 |
sherlockvn
reviewed
Sep 18, 2023
lib/pages/chat_details/chat_details_page_view/same_type_events_list_controller.dart
Outdated
Show resolved
Hide resolved
are images and videos are thumbnails or real files, because it looks slow when loading. And please demo the case when you click to image or videos |
imGok
reviewed
Sep 18, 2023
imGok
reviewed
Sep 18, 2023
nqhhdev
reviewed
Sep 19, 2023
lib/pages/chat_details/chat_details_page_view/media/chat_details_media_page.dart
Outdated
Show resolved
Hide resolved
drminh2807
force-pushed
the
TW-616-List-all-image-video-of-Chat-in-Chat-details
branch
from
808ba61
to
b4e319c
Compare
@sherlockvn it is thumbnail but need load many thumbnails so it will take time, but it just happen on first load, because then it is cached |
drminh2807
force-pushed
the
TW-616-List-all-image-video-of-Chat-in-Chat-details
branch
from
b4e319c
to
c1b7e05
Compare
drminh2807
force-pushed
the
TW-616-List-all-image-video-of-Chat-in-Chat-details
branch
from
c1b7e05
to
b9bff45
Compare
sherlockvn
reviewed
Sep 20, 2023
lib/pages/chat_details/chat_details_page_view/media/chat_details_media_page.dart
Outdated
Show resolved
Hide resolved
sherlockvn
reviewed
Sep 20, 2023
sherlockvn
reviewed
Sep 20, 2023
drminh2807
force-pushed
the
TW-616-List-all-image-video-of-Chat-in-Chat-details
branch
from
b9bff45
to
4b59f65
Compare
hoangdat
reviewed
Sep 20, 2023
hoangdat
reviewed
Sep 20, 2023
hoangdat
reviewed
Sep 20, 2023
hoangdat
reviewed
Sep 20, 2023
lib/pages/chat_details/chat_details_page_view/same_type_events_list_builder.dart
Outdated
Show resolved
Hide resolved
hoangdat
reviewed
Sep 20, 2023
hoangdat
reviewed
Sep 20, 2023
sherlockvn
approved these changes
Sep 21, 2023
hoangdat
reviewed
Sep 21, 2023
hoangdat
approved these changes
Sep 21, 2023
drminh2807
force-pushed
the
TW-616-List-all-image-video-of-Chat-in-Chat-details
branch
from
6dbe17b
to
85c66c9
Compare
nqhhdev
approved these changes
Sep 21, 2023
drminh2807
force-pushed
the
TW-616-List-all-image-video-of-Chat-in-Chat-details
branch
from
85c66c9
to
d644877
Compare
hoangdat
approved these changes
Sep 21, 2023
hoangdat
deleted the
TW-616-List-all-image-video-of-Chat-in-Chat-details
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend on
Issue
Demo
Screen.Recording.2023-09-18.at.10.45.09.mov
RPReplay_Final1695008083.MP4
Image viewer
Screen.Recording.2023-09-19.at.09.49.13.mov