Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TW-99: Clean ToM DB on logout #543

Merged
merged 1 commit into from
Sep 7, 2023
Merged

TW-99: Clean ToM DB on logout #543

merged 1 commit into from
Sep 7, 2023

Conversation

imGok
Copy link
Collaborator

@imGok imGok commented Aug 29, 2023 •
edited
Loading

logoutremove

This Closes #99

@imGok imGok temporarily deployed to PR-543 August 29, 2023 11:51 — with GitHub Actions Inactive
@github-actions
Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/543

@nqhhdev
Copy link
Member

nqhhdev commented Aug 29, 2023

Pls add demo for this case.

sherlockvn
sherlockvn reviewed Aug 30, 2023
View reviewed changes
lib/widgets/matrix.dart Outdated Show resolved Hide resolved
lib/widgets/matrix.dart Show resolved Hide resolved
@imGok imGok temporarily deployed to PR-543 August 30, 2023 13:40 — with GitHub Actions Inactive
@hoangdat
Copy link
Member

hoangdat commented Sep 5, 2023

But I still see the tom db here, but the fluffy is totally cleared

image

@imGok imGok temporarily deployed to PR-543 September 5, 2023 07:23 — with GitHub Actions Inactive
@imGok imGok temporarily deployed to PR-543 September 5, 2023 08:29 — with GitHub Actions Inactive
@imGok
Copy link
Collaborator Author

imGok commented Sep 5, 2023

But I still see the tom db here, but the fluffy is totally cleared

image

I changed some things :

  • Clearing db on login state changed instead of logout action
  • Clear both databases

@imGok imGok changed the title TW-99: Clean ToM DB on logout WIP : TW-99: Clean ToM DB on logout Sep 5, 2023
@imGok imGok changed the title WIP : TW-99: Clean ToM DB on logout TW-99: Clean ToM DB on logout Sep 5, 2023
@imGok imGok temporarily deployed to PR-543 September 5, 2023 09:00 — with GitHub Actions Inactive
@imGok
Copy link
Collaborator Author

imGok commented Sep 5, 2023

image

@imGok imGok temporarily deployed to PR-543 September 6, 2023 13:24 — with GitHub Actions Inactive
@imGok imGok temporarily deployed to PR-543 September 6, 2023 13:30 — with GitHub Actions Inactive
@imGok imGok changed the title TW-99: Clean ToM DB on logout WIP TW-99: Clean ToM DB on logout Sep 6, 2023
@imGok imGok temporarily deployed to PR-543 September 6, 2023 14:28 — with GitHub Actions Inactive
@imGok imGok changed the title WIP TW-99: Clean ToM DB on logout TW-99: Clean ToM DB on logout Sep 7, 2023
@imGok imGok temporarily deployed to PR-543 September 7, 2023 08:07 — with GitHub Actions Inactive
hoangdat
hoangdat reviewed Sep 7, 2023
View reviewed changes
lib/widgets/matrix.dart Outdated
} else {
setUpToMServicesInLogin(c);
if (state == LoginState.loggedIn) {
navigatorContext?.go('/rooms');
} else {
await getIt.get<HiveCollectionToMDatabase>().clear();
await c.clear();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we dont need it? WDYT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me we don't need it because it's already call in logout action

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove it

@imGok
Copy link
Collaborator Author

imGok commented Sep 7, 2023

@hoangdat
-> Login to Linagora
-> Logout
-> Login to tom dev
logoutandlogin

@hoangdat hoangdat merged commit 696bfd4 into main Sep 7, 2023
3 checks passed
@hoangdat hoangdat deleted the TW-99-Clean-db-on-logout branch September 25, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat hoangdat approved these changes

@sherlockvn sherlockvn sherlockvn left review comments

@drminh2807 drminh2807 drminh2807 approved these changes

@dab246 dab246 Awaiting requested review from dab246 dab246 is a code owner

@nqhhdev nqhhdev Awaiting requested review from nqhhdev nqhhdev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean ToM DB when logout
5 participants
@imGok @nqhhdev @hoangdat @drminh2807 @sherlockvn