-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TW-1936: fix the share screen don't show up when sharing an image #1991
TW-1936: fix the share screen don't show up when sharing an image #1991
Conversation
This PR has been deployed to https://linagora.github.io/twake-on-matrix/1991 |
I found an issue for this PR, reproduce steps:
Simulator.Screen.Recording.-.iPhone.15.-.2024-08-08.at.17.13.24.mp4 |
RPReplay_Final1723533405.mov |
Found an other issue on android:
Expectation: when a file is shared only one instance of the app appear and there's no black screen screen-20240820-072605.mp4 |
It doesn't happend to me. Can you delete all twake chat app first before test ? If it persist, please provide the information of your phone. Screen.Recording.2024-08-20.at.15.06.54.mov
|
Failed for this case:
|
cb22aa8
to
3007527
Compare
Hi @sherlockvn I found an issue on Mobile (iOS and Android) related to your PR. Screenrecorder-20240906-103340.mp4Simulator.Screen.Recording.-.iPhone.15.-.2024-09-06.at.10.23.06.mp4Tested on main branchSimulator.Screen.Recording.-.iPhone.15.-.2024-09-06.at.10.42.35.mp4 |
ada90f3
to
cef7dad
Compare
Fixed
Screen.Recording.2024-09-08.at.8.25.27.PM.mov |
…en open sharing screen
1ae57d5
to
eaf9e2f
Compare
…push when open sharing screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on iOS and Android, works well for me.
Ticket
Related issue
#1936
Solution
Outline the implemented solution, detailing the changes made and how they address the issue
Change from
go
topush
Resolved
Attach screenshots or videos demonstrating the changes
Screen.Recording.2024-08-07.at.16.23.15.mov
RPReplay_Final1723019028.MP4