Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-1936: fix the share screen don't show up when sharing an image #1991

Merged
merged 7 commits into from
Sep 10, 2024

Conversation

sherlockvn
Copy link
Contributor

@sherlockvn sherlockvn commented Aug 7, 2024

Ticket

Related issue
#1936

Solution

Outline the implemented solution, detailing the changes made and how they address the issue
Change from go to push

Resolved

Attach screenshots or videos demonstrating the changes

  • Web:
  • Android:
Screen.Recording.2024-08-07.at.16.23.15.mov
  • IOS:
RPReplay_Final1723019028.MP4

Copy link

github-actions bot commented Aug 7, 2024

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1991

@nqhhdev
Copy link
Member

nqhhdev commented Aug 8, 2024

I found an issue for this PR, reproduce steps:

  • Open the app and go to the chat list
  • Open a chat and go to chat profile
  • Leave the app and share something (File, image, text)
  • Received share and open share screen
  • Send to another chat.
  • Can't open exactly chat and can't back to previous screen
Simulator.Screen.Recording.-.iPhone.15.-.2024-08-08.at.17.13.24.mp4

@sherlockvn
Copy link
Contributor Author

I found an issue for this PR, reproduce steps:

  • Open the app and go to the chat list
  • Open a chat and go to chat profile
  • Leave the app and share something (File, image, text)
  • Received share and open share screen
  • Send to another chat.
  • Can't open exactly chat and can't back to previous screen

Simulator.Screen.Recording.-.iPhone.15.-.2024-08-08.at.17.13.24.mp4

RPReplay_Final1723533405.mov

@Te-Z
Copy link
Contributor

Te-Z commented Aug 20, 2024

Found an other issue on android:

  • start typing something in search text field
  • leave the app and share something
  • the file is successfully shared
  • we now have two instances of twake chat (one with the sharing, the other one looks like the search screen)
  • when trying to go back on the first one there's a black screen, the only solution is to kill the app

Expectation: when a file is shared only one instance of the app appear and there's no black screen

screen-20240820-072605.mp4

@sherlockvn
Copy link
Contributor Author

sherlockvn commented Aug 20, 2024

It doesn't happend to me. Can you delete all twake chat app first before test ? If it persist, please provide the information of your phone.

Screen.Recording.2024-08-20.at.15.06.54.mov

Found an other issue on android:

  • start typing something in search text field
  • leave the app and share something
  • the file is successfully shared
  • we now have two instances of twake chat (one with the sharing, the other one looks like the search screen)
  • when trying to go back on the first one there's a black screen, the only solution is to kill the app

Expectation: when a file is shared only one instance of the app appear and there's no black screen

screen-20240820-072605.mp4

@nqhhdev
Copy link
Member

nqhhdev commented Aug 29, 2024

Failed for this case:

  • Open Settings
  • Open account profile
  • Click on Switch accounts or Add another account → open bottom sheet
  • leave the app
  • Share something for Twake Chat
  • Open share screen however can't close bottom sheet

@nqhhdev
Copy link
Member

nqhhdev commented Sep 6, 2024

Hi @sherlockvn I found an issue on Mobile (iOS and Android) related to your PR.

Screenrecorder-20240906-103340.mp4
Simulator.Screen.Recording.-.iPhone.15.-.2024-09-06.at.10.23.06.mp4

Tested on main branch

Simulator.Screen.Recording.-.iPhone.15.-.2024-09-06.at.10.42.35.mp4

@sherlockvn
Copy link
Contributor Author

sherlockvn commented Sep 8, 2024

Fixed

Hi @sherlockvn I found an issue on Mobile (iOS and Android) related to your PR.

Screenrecorder-20240906-103340.mp4
Simulator.Screen.Recording.-.iPhone.15.-.2024-09-06.at.10.23.06.mp4

Tested on main branch

Simulator.Screen.Recording.-.iPhone.15.-.2024-09-06.at.10.42.35.mp4

Screen.Recording.2024-09-08.at.8.25.27.PM.mov

@sherlockvn sherlockvn force-pushed the TW-1936/wrong-screen-displayed-when-sharing-image branch from 1ae57d5 to eaf9e2f Compare September 9, 2024 09:29
Copy link
Member

@nqhhdev nqhhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS and Android, works well for me.

@hoangdat hoangdat merged commit 7661c07 into main Sep 10, 2024
7 checks passed
@hoangdat hoangdat deleted the TW-1936/wrong-screen-displayed-when-sharing-image branch September 10, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants