Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-131: send one image without caption #164

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

sherlockvn
Copy link
Collaborator

Screen.Recording.2023-06-18.at.21.52.18.mov
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-06-18.at.23.54.46.mp4

@sherlockvn sherlockvn force-pushed the TW-131/send-one-image-without-caption branch from e55dd51 to 1d5e937 Compare June 18, 2023 16:57
@hoangdat
Copy link
Member

I think you still miss the progress icon in the center of image
image

lib/pages/chat/chat.dart Show resolved Hide resolved
lib/pages/chat/chat.dart Outdated Show resolved Hide resolved
lib/pages/chat/events/message_content.dart Outdated Show resolved Hide resolved
lib/utils/matrix_sdk_extensions/event_extension.dart Outdated Show resolved Hide resolved
@nqhhdev
Copy link
Member

nqhhdev commented Jun 19, 2023

Pls demo some case :

  1. If sent error => Retry send an image
  2. Please send an image with size = maxSendingImage
  3. Please send an image with sized > maxSendingImage

@sherlockvn
Copy link
Collaborator Author

I think you still miss the progress icon in the center of image image

Currently, there is no progress for upload image, so we can only fake it

@sherlockvn
Copy link
Collaborator Author

Pls demo some case :

  1. If sent error => Retry send an image
  2. Please send an image with size = maxSendingImage
  3. Please send an image with sized > maxSendingImage

It's the error case for sure

@sherlockvn sherlockvn force-pushed the TW-131/send-one-image-without-caption branch from 162f63a to 8a05e6d Compare June 19, 2023 07:59
@hoangdat hoangdat merged commit 890a965 into main Jun 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants