TW-136 feat: set avatar group chat at creation #156

imGok · 2023-06-13T18:04:35Z

This Closes

DEMO :
Create group with avatar :

Create group without avatar :

Avatar too big :

lib/pages/new_group/new_group_chat_info.dart

hoangdat · 2023-06-13T23:58:34Z

Great!!! but what is the limitation of avatar?

lib/pages/new_group/new_group_info_controller.dart

hoangdat · 2023-06-14T00:23:31Z

as I saw in the demo, user need to wait for a long time after submitting the creation. Not a good UX.

Please create the interactor with the output is the stream of state we will find the way to show the progress of creation in UI.

lib/pages/new_group/new_group_chat_info.dart

lib/domain/app_state/room/create_room_success.dart

lib/pages/new_group/new_group_info_controller.dart

hoangdat

anw, I like the way you are working now. 💪

lib/di/room/room_di.dart

lib/domain/model/contact/new_room_informations.dart

lib/domain/usecase/create_room_interactor.dart

lib/pages/new_group/new_group.dart

lib/pages/new_group/new_group_info_controller.dart

lib/domain/app_state/room/create_room_success.dart

lib/pages/new_group/new_group.dart

lib/pages/new_private_chat/create_room_controller.dart

lib/pages/new_group/new_group.dart

hoangdat · 2023-06-16T01:49:03Z

It is hard for me to follow the previous comments, DONT DO IT. It wastes a lot of time of reviewers

lib/domain/usecase/create_room_interactor.dart

lib/domain/app_state/room/create_room_success.dart

lib/pages/new_group/new_group.dart

lib/domain/app_state/room/create_room_success.dart

lib/pages/new_group/new_group.dart

imGok · 2023-06-19T15:31:32Z

I put a default value to prevent blink blink @hoangdat

sherlockvn · 2023-06-20T02:31:40Z

lib/pages/new_group/new_group.dart


  final selectedContactsMapNotifier = ValueNotifier<Map<PresentationContact, bool>>({});
  final haveSelectedContactsNotifier = ValueNotifier(false);
  final haveGroupNameNotifier = ValueNotifier(false);
  final isEnableEEEncryptionNotifier = ValueNotifier(true);
+  final avatarNotifier = ValueNotifier<MatrixFile?>(null);
+
+  final int maxFileSizeDefault = 5 * 1024 * 1024;


you should clarify this variable. is it in MB or KB or GB ?. maxFileSizeDefault => maxFileSizeDefaultInMB

can we remove it?

You are right!

@hoangdat I think it's a good solution in case there is no upload size limit in the config, low connection etc. It prevents having a blank space. you have the final word

imGok · 2023-06-20T14:20:05Z

@hoangdat I didn't manage to find a solution with VROUTER library. I removed an useless listening stream since it's an action. The interactor stream is being listened when the user creates a room then every listeners are unsubscribed after done event.

When the "done" event is fired, subscribers are unsubscribed before receiving the event. After the event has been sent, the stream has no subscribers. Adding new subscribers to a broadcast stream after this point is allowed, but they will just receive a new "done" event as soon as possible.

This Closes #136

hoangdat · 2023-06-19T14:23:02Z

lib/domain/usecase/create_room_interactor.dart

+          final Stream<Either<Failure, Success>> setRoomAvatarStream = setRoomAvatarInteractor.execute(matrixClient, roomId, newRoomInformations.avatar);
+          yield* setRoomAvatarStream;


Suggested change

final Stream<Either<Failure, Success>> setRoomAvatarStream = setRoomAvatarInteractor.execute(matrixClient, roomId, newRoomInformations.avatar);

yield* setRoomAvatarStream;

yield* setRoomAvatarInteractor.execute(matrixClient, roomId, newRoomInformations.avatar);

hoangdat · 2023-06-19T14:38:05Z

lib/pages/new_group/new_group_chat_info.dart

-              ),
+            FutureBuilder<ServerConfig>(
+              future: Matrix.of(context).client.getConfig(),
+              builder: (context, snapshot) {


is it any blink blink effect?

The value switches from 5 to 100 to wait for data. I can put a loading indicator instead if_ you want

assets/l10n/intl_en.arb

hoangdat · 2023-06-20T12:15:53Z

lib/pages/new_group/new_group.dart


  final selectedContactsMapNotifier = ValueNotifier<Map<PresentationContact, bool>>({});
  final haveSelectedContactsNotifier = ValueNotifier(false);
  final haveGroupNameNotifier = ValueNotifier(false);
  final isEnableEEEncryptionNotifier = ValueNotifier(true);
+  final avatarNotifier = ValueNotifier<MatrixFile?>(null);
+
+  final int maxFileSizeDefault = 5 * 1024 * 1024;


can we remove it?

lib/pages/new_private_chat/create_room_controller.dart

dab246 · 2023-06-21T06:17:13Z

Demo

Screen.Recording.2023-06-21.at.12.46.00.mov

imGok · 2023-06-21T07:50:59Z

Thank you for the help @dab246 !

The main point of this feature is to be redirected right after clicking creating the room.
Scenario should be like this :
Click : Redirection to new room and meanwhile creating / settings new avatar.

That's why we can't cancel the stream until set avatar is finished.

But if @hoangdat changed his idea about the UX, we can use your commit

(You can see the intended UX on GIF description)

hoangdat · 2023-07-11T05:23:36Z

I will close this PR, but still keep it to make some reference. I explain more information in the ticket #136

imGok changed the title ~~feat: set avatar group chat at creation~~ TW-136 feat: set avatar group chat at creation Jun 13, 2023

hoangdat reviewed Jun 13, 2023

View reviewed changes

lib/pages/new_group/new_group_chat_info.dart Outdated Show resolved Hide resolved

hoangdat reviewed Jun 14, 2023

View reviewed changes

lib/pages/new_group/new_group_info_controller.dart Outdated Show resolved Hide resolved

imGok force-pushed the tw_136_create_grp_photo branch from 1fe6cd9 to 1f3d29a Compare June 14, 2023 18:06

sherlockvn reviewed Jun 14, 2023

View reviewed changes

lib/pages/new_group/new_group_chat_info.dart Outdated Show resolved Hide resolved

lib/domain/app_state/room/create_room_success.dart Outdated Show resolved Hide resolved

lib/pages/new_group/new_group_info_controller.dart Outdated Show resolved Hide resolved

hoangdat reviewed Jun 14, 2023

View reviewed changes

imGok force-pushed the tw_136_create_grp_photo branch 2 times, most recently from 3226bff to e66fe7b Compare June 15, 2023 18:01

hoangdat reviewed Jun 16, 2023

View reviewed changes

lib/domain/usecase/create_room_interactor.dart Outdated Show resolved Hide resolved

sherlockvn reviewed Jun 19, 2023

View reviewed changes

lib/domain/app_state/room/create_room_success.dart Outdated Show resolved Hide resolved

lib/pages/new_group/new_group.dart Outdated Show resolved Hide resolved

hoangdat reviewed Jun 19, 2023

View reviewed changes

imGok force-pushed the tw_136_create_grp_photo branch from ef75f7c to 2e1d77e Compare June 19, 2023 15:42

sherlockvn reviewed Jun 20, 2023

View reviewed changes

Julian KOUNE added 7 commits June 20, 2023 16:26

feat: set avatar group chat at creation

9738cdc

This Closes #136

feat: room avatar max size

9f2fd81

feat: preview avatar group chat

6b56b55

fixup! feat: set avatar group chat at creation

e2819f6

fixup! feat: room avatar max size

e2681eb

fixup! fixup! feat: set avatar group chat at creation

a26c783

fixup! fixup! fixup! feat: set avatar group chat at creation

9946427

imGok force-pushed the tw_136_create_grp_photo branch from 279aa8c to 9946427 Compare June 20, 2023 14:44

hoangdat reviewed Jun 20, 2023

View reviewed changes

fixup! fixup! fixup! fixup! feat: set avatar group chat at creation

4deee6a

dab246 reviewed Jun 21, 2023

View reviewed changes

lib/pages/new_private_chat/create_room_controller.dart Outdated Show resolved Hide resolved

TW-136 Handle create room with avatar

c8919a3

hoangdat closed this Jul 11, 2023

hoangdat deleted the tw_136_create_grp_photo branch August 8, 2023 11:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TW-136 feat: set avatar group chat at creation #156

TW-136 feat: set avatar group chat at creation #156

imGok commented Jun 13, 2023 •

edited by nqhhdev

Loading

hoangdat commented Jun 13, 2023

hoangdat commented Jun 14, 2023 •

edited

Loading

hoangdat left a comment

hoangdat commented Jun 16, 2023

imGok commented Jun 19, 2023

sherlockvn Jun 20, 2023

hoangdat Jun 20, 2023

imGok Jun 20, 2023

imGok Jun 21, 2023

imGok commented Jun 20, 2023

hoangdat Jun 19, 2023

hoangdat Jun 19, 2023

imGok Jun 20, 2023

hoangdat Jun 20, 2023

dab246 commented Jun 21, 2023

imGok commented Jun 21, 2023 •

edited

Loading

hoangdat commented Jul 11, 2023

		final Stream<Either<Failure, Success>> setRoomAvatarStream = setRoomAvatarInteractor.execute(matrixClient, roomId, newRoomInformations.avatar);
		yield* setRoomAvatarStream;

TW-136 feat: set avatar group chat at creation #156

TW-136 feat: set avatar group chat at creation #156

Conversation

imGok commented Jun 13, 2023 • edited by nqhhdev Loading

hoangdat commented Jun 13, 2023

hoangdat commented Jun 14, 2023 • edited Loading

hoangdat left a comment

Choose a reason for hiding this comment

hoangdat commented Jun 16, 2023

imGok commented Jun 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

imGok commented Jun 20, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dab246 commented Jun 21, 2023

imGok commented Jun 21, 2023 • edited Loading

hoangdat commented Jul 11, 2023

imGok commented Jun 13, 2023 •

edited by nqhhdev

Loading

hoangdat commented Jun 14, 2023 •

edited

Loading

imGok commented Jun 21, 2023 •

edited

Loading