TW-853: Create StreamSubscription for getContact

linagora · Oct 27, 2023 · 091e912 · 091e912
1 parent 9eb5800
commit 091e912
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/lib/pages/new_private_chat/search_contacts_controller.dart b/lib/pages/new_private_chat/search_contacts_controller.dart
@@ -83,5 +83,7 @@ mixin class SearchContactsMixinController {
     _debouncer.cancel();
     _getContactController?.dispose();
     textEditingController.dispose();
+    isSearchModeNotifier.dispose();
+    searchFocusNode.dispose();
   }
 }
diff --git a/lib/pages/search/get_contacts_controller.dart b/lib/pages/search/get_contacts_controller.dart
@@ -1,3 +1,5 @@
+import 'dart:async';
+
 import 'package:dartz/dartz.dart';
 import 'package:fluffychat/app_state/failure.dart';
 import 'package:fluffychat/app_state/success.dart';
@@ -18,6 +20,9 @@ class GetContactsController {
   final contactsNotifier = ValueNotifier<Either<Failure, Success>>(
     const Right(GetContactsInitial()),
   );
+
+  StreamSubscription? _getContactsSubscription;
+
   final refreshController = TwakeRefreshController();
   bool _isLoadMore = false;
   Success? _lastSuccess;
@@ -26,7 +31,7 @@ class GetContactsController {
     required String keyword,
     int limit = AppConfig.fetchContactsLimit,
   }) {
-    _getContactsInteractor
+    _getContactsSubscription = _getContactsInteractor
         .execute(keyword: keyword, offset: 0, limit: limit)
         .listen((event) {
       contactsNotifier.value = event.map((success) {
@@ -52,7 +57,7 @@ class GetContactsController {
       return;
     }
     _isLoadMore = true;
-    _getContactsInteractor
+    _getContactsSubscription = _getContactsInteractor
         .execute(
       keyword: success.keyword,
       offset: success.offset,
@@ -77,5 +82,6 @@ class GetContactsController {
 
   void dispose() {
     contactsNotifier.dispose();
+    _getContactsSubscription?.cancel();
   }
 }
diff --git a/lib/widgets/twake_components/twake_preview_link/twake_link_preview_item.dart b/lib/widgets/twake_components/twake_preview_link/twake_link_preview_item.dart
@@ -46,8 +46,10 @@ class TwakeLinkPreviewItem extends StatelessWidget {
                 height: TwakeLinkPreviewItemStyle.heightMxcImagePreview,
                 width: TwakeLinkPreviewItemStyle.heightMxcImagePreview,
                 child: MxcImage(
+                  height: TwakeLinkPreviewItemStyle.heightMxcImagePreview,
+                  width: TwakeLinkPreviewItemStyle.heightMxcImagePreview,
                   uri: urlPreviewPresentation.imageUri,
-                  fit: BoxFit.fill,
+                  fit: BoxFit.cover,
                   isThumbnail: false,
                   placeholder: (_) => const SizedBox(),
                 ),