Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run nerdctl with suid in nc #106

Closed
wants to merge 1 commit into from

Conversation

afbjorklund
Copy link
Member

This is a Rancher Desktop specific setting

Running nerdctl requires root, in Alpine

This is a Rancher Desktop specific setting

Running `nerdctl` requires root, in Alpine

Signed-off-by: Anders F Björklund <[email protected]>
@afbjorklund
Copy link
Member Author

@jandubois : broke this out from the "nerdctl" edition

@jandubois
Copy link
Member

I'm happy to merge this, if you need this for any other edition, but it should not be enabled for the rd edition because we run nerdctl via sudo already. Maybe it makes sense to change it; I have to think about it.

I'm fine with adding more editions to this repo, if you think they will be useful. But as I mentioned in the other PR, I'm thinking about removing the rd edition from this repo because it is maintained in a fork. Mostly to avoid the churn in this repo, but also to be able to have rancher-desktop maintainers be able to review/merge PRs.

@jandubois
Copy link
Member

Closing this because #130 removes the setting to install nerdctl.

@jandubois jandubois closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants