Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: rename nerdctl to nerdctl-full #105

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

afbjorklund
Copy link
Member

Since the bundle package also contains other software.

These are also available as regular Alpine packages.

Since the bundle package also contains other software.

These are also available as regular Alpine packages.

Signed-off-by: Anders F Björklund <[email protected]>
@afbjorklund
Copy link
Member Author

@jandubois : broke this out from the "nerdctl" edition

@AkihiroSuda
Copy link
Member

I'm not sure about this.
I'd say "nerdctl-full" refers to the upstream nerdctl-full distribution ( https://github.com/containerd/nerdctl/releases/download/v1.4.0/nerdctl-full-1.4.0-linux-amd64.tar.gz )

@afbjorklund
Copy link
Member Author

Currently we download "nerdctl-full", and rename it to "nerdctl"

nerdctl-$(NERDCTL_VERSION)-$(ARCH):
        curl -o $@ -Ls https://github.com/containerd/nerdctl/releases/download/v$(NERDCTL_VERSION)/nerdctl-full-$(NERDCTL_VERSION)-linux-$(ARCH_ALIAS).tar.gz

Copy link
Member

@jandubois jandubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jandubois jandubois merged commit 88bd124 into lima-vm:main Jun 29, 2023
@jandubois
Copy link
Member

I've merged this change because it makes sense to normalize the name.

It feels a bit pointless though, as rd is the only edition that uses it, and it is no longer built out of this repo, but from https://github.com/rancher-sandbox/alpine-lima.

And then we have #77 about letting Lima bundle nerdctl, just like for all other images.

Anyways, I've been wondering if I should remove the rd specific config options from this repo and maintain them purely in the downstream fork. What do you think @AkihiroSuda ?

@AkihiroSuda
Copy link
Member

rd

SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants