Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor exception handling of Binary\Loader\ChainLoader class #1434

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open

Refactor exception handling of Binary\Loader\ChainLoader class #1434

wants to merge 2 commits into from

Commits on Nov 25, 2021

  1. squashed commits refactoring error handling logic of Liip\ImagineBund… 

    …le\Binary\Loader\ChainLoader:

- refactored Liip\ImagineBundle\Binary\Loader\ChainLoader error handling logic to exception classes instead of prior half-baked and confusing handling inside loader inself
- testing alternate ChainNotLoadableException::compileExceptionMessage() implementation
- cleanup of refactored Liip\ImagineBundle\Binary\Loader\ChainLoader and its related exceptions
- ran php-cs-fixer on prior ChainLoader related changes
- updates per reviews from @dbu and @franmomu
    @robfrawley
    robfrawley committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    e49602b View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. extended tests to properly assert requirements of new chainloader err… 

    …or handling implementation and updates per reviews from @dbu and @franmomu
    @robfrawley
    robfrawley committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    3a76b4b View commit details
    Browse the repository at this point in the history