OS-47 #8
Open
OS-47 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(- one line change)
|
(The project isn't working yet. the major changes are in the OS-46 and they are not ready yet. but this covers the OS-47). there is more explanation in the jira. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved:
Problem 1:
In the original code, the program tried to open "red_detector_key.pem" file. If the user inserted his pem file, the program would have crashed.
problem 2:
creating a key pair with the same name- "red_detector_key". In my case for example. this is a key pair in the aws but I dont have the pem file for it locally. so the program crashed, either if I wanted to use it or not.