-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the dependency on Guava. #524
Remove the dependency on Guava. #524
Conversation
….checkNotNull` for checking.
…ommon.primitives.Bytes`.
Currently, Java 8 does not have built-in support for Update: |
# Conflicts: # src/main/java/org/stellar/sdk/Predicate.java # src/main/java/org/stellar/sdk/responses/PredicateDeserializer.java
…oogle.common.primitives.Bytes`.
ok, if interested to avoid the additional dep on commons-codec, can get by with creating a helper method in plain java using |
This PR is almost completed. After checking it again tomorrow, I will request a review :-) |
commons-codec looks relatively simple and doesn't have a series of dependencies like Guava, so I think it would be great to introduce it, right? |
3369077
to
cde613d
Compare
Hi @sreuland, this PR is ready for review, it's big PR 😂 |
Hi @sreuland, It seems that the conflict has not been resolved correctly. Please check https://github.com/stellar/java-stellar-sdk/pull/524/files#diff-04e963815abf17aa3afc8545dd7431ba59aa861e57e3a04f53c5c33b82482305L12 Do you mind if I revert this PR and then create a new PR to merge into the soroban branch, and finally squash these three commits on the soroban branch? |
This reverts commit 302aba5.
I have already fixed this issue in the soroban branch and pushed the code after squashing by using |
ok, I had done manual merge of conflicts in SimulateTransactionResponse and SorabanServerTest after porting soroban and looks like chose incorrect direction, thanks for resolving. |
Part of #496
This PR does not include XDR changes, I need to wait for the merge of stellar/xdrgen#168 before initiating a separate XDR-related PR.
This PR is almost completed, but before merging it, we need to merge #525 and #527 first and remove
com.google.guava:guava:32.1.2-android
in build.gradle.