Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hashmail logging cleanup #1176

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Hashmail logging cleanup #1176

merged 2 commits into from
Nov 11, 2024

Conversation

ffranr
Copy link
Contributor

@ffranr ffranr commented Nov 7, 2024

No description provided.

@ffranr
proof: improve hashmail courier proof delivery log messages
80bbe42 
Improve comments, log messages, and error messages.
@ffranr ffranr requested a review from guggero November 7, 2024 11:34
@ffranr ffranr self-assigned this Nov 7, 2024
@coveralls
Copy link

coveralls commented Nov 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11765814217

Details

  • 0 of 88 (0.0%) changed or added relevant lines in 2 files are covered.
  • 22 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.06%) to 40.65%
Changes Missing Coverage Covered Lines Changed/Added Lines %
proof/courier.go 0 31 0.0%
tapfreighter/chain_porter.go 0 57 0.0%
Files with Coverage Reduction New Missed Lines %
tapfreighter/chain_porter.go 2 0.0%
tapgarden/planter.go 2 74.87%
commitment/tap.go 2 84.43%
tapchannel/aux_leaf_signer.go 2 35.92%
proof/courier.go 3 9.55%
tapdb/universe.go 4 80.91%
tapdb/multiverse.go 7 60.32%
Totals Coverage Status
Change from base Build 11720128932: -0.06%
Covered Lines: 24686
Relevant Lines: 60728
💛 - Coveralls

guggero
guggero reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the logging improvements! One question about the last commit.

tapfreighter/chain_porter.go Outdated Show resolved Hide resolved
proof/courier.go Outdated Show resolved Hide resolved
@ffranr
proof: report proof delivery status over for each transfer output
f9581d5 
This commit introduces new logging functionality that reports the
overall proof delivery status for each output in the current transfer.
@ffranr ffranr requested a review from guggero November 10, 2024 14:08
@ffranr ffranr requested a review from jharveyb November 10, 2024 14:10
jharveyb
jharveyb approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@ffranr ffranr added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit d81bd74 Nov 11, 2024
18 checks passed
@guggero guggero deleted the hashmail-deliver-logging branch November 12, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jharveyb jharveyb jharveyb approved these changes

@guggero guggero guggero approved these changes

Assignees

@ffranr ffranr

Labels
None yet
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ffranr @coveralls @guggero @jharveyb