Align RFQ reject message with BLIP #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change reject message data encoding to use new TLV libraries. This is a breaking change as the RejectErr field will now be encoded as a single TLV field. This commit also bumps the reject msg current version from 0 to 1.
This change ensures consistent naming of message data types across request, accept, and reject message types.
Pull Request Test Coverage Report for Build 10958269291Details
💛 - Coveralls |
|
I've changed this to draft to ensure this PR is merged with the rest of the RFQ breaking changes in the same release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the RFQ reject wire message with the BLIP changes found here Roasbeef/blips#4
This PR is related to #871
These changes require a quote reject wire message version bump. We need to ensure that all RFQ breaking changes go into the same release. I've decided to spin them into their own PR because the scope of change is very narrow, these commits are small.