[custom channels]: update to tagged version of lnd #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
changed the title
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
78fb484
to
ed97350
Compare
12 tasks
Pull Request Test Coverage Report for Build 10958990422Details
💛 - Coveralls |
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
ed97350
to
ed3e7b3
Compare
A recent change to the lnd SCID alias RPCs requires us to generate SCID aliases in a certain range. Because we derive the alias from the randomly generated RFQ ID, we need to do some shifting arithmetic to arrive at an acceptable alias.
We now get custom_channel_data fields in the ListInvoices/LookupInvoice as well as in the ListPayments RPC. We add those fields to our data parser implementation.
This commit unifies the use of the lfn.Result return type as a preparation for the next commit, where we change a bunch of function/method signatures to use the Result type as well.
guggero
force-pushed
the
update-to-lnd-18-4
branch
from
ed3e7b3
to
5f1e5b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
lnddependency to use the latest version of themasterbranch (once we're close to releasingv0.18.4-beta).Depends on #1120.
Depends on lightningnetwork/lnd#8960.
Depends on lightninglabs/lndclient#192.
Full serialized dependency list can be seen here: lightninglabs/lightning-terminal#848