Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tapdb: improve batch marshalling #1127

Merged
merged 1 commit into from
Sep 18, 2024
Merged

tapdb: improve batch marshalling #1127

merged 1 commit into from
Sep 18, 2024

Conversation

jharveyb
Copy link
Collaborator

Addresses #1125 .

guggero
guggero approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Roasbeef
Roasbeef approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dstadulis dstadulis added this to the v0.4.2 milestone Sep 17, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10909138510

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.003%) to 40.402%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tapdb/asset_minting.go 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
commitment/tap.go 1 83.64%
tapdb/addrs.go 2 79.04%
tappsbt/create.go 2 53.22%
universe/interface.go 4 50.22%
tapdb/universe.go 4 80.91%
Totals Coverage Status
Change from base Build 10901514108: 0.003%
Covered Lines: 24214
Relevant Lines: 59933
💛 - Coveralls

@Roasbeef Roasbeef added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 4da20cd Sep 18, 2024
18 checks passed
@guggero guggero deleted the batch_marshal_fixes branch September 18, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roasbeef Roasbeef Roasbeef approved these changes

@guggero guggero guggero approved these changes

Assignees

@jharveyb jharveyb

Labels
None yet
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
v0.4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@jharveyb @coveralls @Roasbeef @guggero @dstadulis