RFQ cleanup #1124
Merged
RFQ cleanup #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only want a single place where SCIDs are calculated from the RFQ ID. This is especially important due to a future change required where lnd will only accept SCIDs in a certain range and we'll need to deterministically shift the derived SCID to be within that range.
Eliminating these error types ensures that all current errors align with those documented in the BLIP.
Pull Request Test Coverage Report for Build 10887430285Details
💛 - Coveralls |
GeorgeTsagk
approved these changes
Sep 17, 2024
|
|
||
| scidInteger := binary.BigEndian.Uint64(scidBytes) | ||
| return SerialisedScid(scidInteger) | ||
| return q.ID.Scid() |
There was a problem hiding this comment.
note for commit message:
This code should be relevant for generating RFQ scids within range: lnd/aliasmgr/aliasmgr.go
There was a problem hiding this comment.
Yeah, I have that code in a WIP branch (lnd-0-19-staging-rebased already:
taproot-assets/rfqmsg/messages.go
Line 41 in 97be885
guggero
approved these changes
Sep 17, 2024
|
|
||
| scidInteger := binary.BigEndian.Uint64(scidBytes) | ||
| return SerialisedScid(scidInteger) | ||
| return q.ID.Scid() |
There was a problem hiding this comment.
Yeah, I have that code in a WIP branch (lnd-0-19-staging-rebased already:
taproot-assets/rfqmsg/messages.go
Line 41 in 97be885
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-breaking cleanup commits for the RFQ packages.