[rfq]: Refactor according to proposed changes for better precision #3143
main.yaml
on: pull_request
Matrix: run unit tests
Sqlc check
4m 58s
RPC check
3m 25s
go mod check
2m 32s
test vector check
33s
migration version check
15s
Compilation check
23s
sample configuration check
3m 35s
Docker build check
2m 58s
cross compilation
59s
Lint check
2m 13s
Format check
2m 33s
run itests
2m 8s
run itests postgres
2m 4s
run LiT tests
18m 24s
finish
6s
Annotations
84 errors and 18 warnings
Compilation check:
rfq/order.go#L104
quote.Request.AssetAmount undefined (type rfqmsg.BuyRequest has no field or method AssetAmount)
|
Compilation check:
rfq/order.go#L105
quote.Expiry undefined (type rfqmsg.BuyAccept has no field or method Expiry)
|
Compilation check:
rfq/order.go#L220
quote.Request.AssetAmount undefined (type rfqmsg.SellRequest has no field or method AssetAmount)
|
Compilation check:
rfq/order.go#L221
quote.Expiry undefined (type rfqmsg.SellAccept has no field or method Expiry)
|
Compilation check:
rfq/stream.go#L149
too many arguments in call to rfqmsg.NewBuyAcceptFromRequest
|
Compilation check:
rfq/stream.go#L155
too many arguments in call to rfqmsg.NewSellAcceptFromRequest
|
Compilation check
Process completed with exit code 1.
|
test vector check:
rfq/order.go#L104
quote.Request.AssetAmount undefined (type rfqmsg.BuyRequest has no field or method AssetAmount)
|
test vector check:
rfq/order.go#L105
quote.Expiry undefined (type rfqmsg.BuyAccept has no field or method Expiry)
|
test vector check:
rfq/order.go#L220
quote.Request.AssetAmount undefined (type rfqmsg.SellRequest has no field or method AssetAmount)
|
test vector check:
rfq/order.go#L221
quote.Expiry undefined (type rfqmsg.SellAccept has no field or method Expiry)
|
test vector check:
rfq/stream.go#L149
too many arguments in call to rfqmsg.NewBuyAcceptFromRequest
|
test vector check:
rfq/stream.go#L155
too many arguments in call to rfqmsg.NewSellAcceptFromRequest
|
test vector check
Process completed with exit code 2.
|
cross compilation
quote.Request.AssetAmount undefined (type rfqmsg.BuyRequest has no field or method AssetAmount)
|
cross compilation
quote.Expiry undefined (type rfqmsg.BuyAccept has no field or method Expiry)
|
cross compilation
quote.Request.AssetAmount undefined (type rfqmsg.SellRequest has no field or method AssetAmount)
|
cross compilation
quote.Expiry undefined (type rfqmsg.SellAccept has no field or method Expiry)
|
cross compilation
too many arguments in call to rfqmsg.NewBuyAcceptFromRequest
|
cross compilation
too many arguments in call to rfqmsg.NewSellAcceptFromRequest
|
cross compilation
Process completed with exit code 2.
|
run unit tests (unit-cover):
rfq/order.go#L104
quote.Request.AssetAmount undefined (type rfqmsg.BuyRequest has no field or method AssetAmount)
|
run unit tests (unit-cover):
rfq/order.go#L105
quote.Expiry undefined (type rfqmsg.BuyAccept has no field or method Expiry)
|
run unit tests (unit-cover):
rfq/order.go#L220
quote.Request.AssetAmount undefined (type rfqmsg.SellRequest has no field or method AssetAmount)
|
run unit tests (unit-cover):
rfq/order.go#L221
quote.Expiry undefined (type rfqmsg.SellAccept has no field or method Expiry)
|
run unit tests (unit-cover):
rfq/stream.go#L149
too many arguments in call to rfqmsg.NewBuyAcceptFromRequest
|
run unit tests (unit-cover):
rfq/stream.go#L155
too many arguments in call to rfqmsg.NewSellAcceptFromRequest
|
run unit tests (unit-cover)
Process completed with exit code 2.
|
run unit tests (unit dbbackend=postgres):
rfq/order.go#L104
quote.Request.AssetAmount undefined (type rfqmsg.BuyRequest has no field or method AssetAmount)
|
run unit tests (unit dbbackend=postgres):
rfq/order.go#L105
quote.Expiry undefined (type rfqmsg.BuyAccept has no field or method Expiry)
|
run unit tests (unit dbbackend=postgres):
rfq/order.go#L220
quote.Request.AssetAmount undefined (type rfqmsg.SellRequest has no field or method AssetAmount)
|
run unit tests (unit dbbackend=postgres):
rfq/order.go#L221
quote.Expiry undefined (type rfqmsg.SellAccept has no field or method Expiry)
|
run unit tests (unit dbbackend=postgres):
rfq/stream.go#L149
too many arguments in call to rfqmsg.NewBuyAcceptFromRequest
|
run unit tests (unit dbbackend=postgres):
rfq/stream.go#L155
too many arguments in call to rfqmsg.NewSellAcceptFromRequest
|
run unit tests (unit dbbackend=postgres):
rfqmsg/accept_test.go#L49
unknown field Expiry in struct literal of type BuyAccept
|
run unit tests (unit dbbackend=postgres):
rfqmsg/accept_test.go#L51
unknown field InAssetPrice in struct literal of type BuyAccept
|
run unit tests (unit dbbackend=postgres):
rfqmsg/accept_test.go#L52
unknown field OutAssetPrice in struct literal of type BuyAccept
|
run unit tests (unit dbbackend=postgres):
rfqmsg/accept_test.go#L61
unknown field Expiry in struct literal of type BuyAccept
|
run itests postgres:
rfq/order.go#L104
quote.Request.AssetAmount undefined (type rfqmsg.BuyRequest has no field or method AssetAmount)
|
run itests postgres:
rfq/order.go#L105
quote.Expiry undefined (type rfqmsg.BuyAccept has no field or method Expiry)
|
run itests postgres:
rfq/order.go#L220
quote.Request.AssetAmount undefined (type rfqmsg.SellRequest has no field or method AssetAmount)
|
run itests postgres:
rfq/order.go#L221
quote.Expiry undefined (type rfqmsg.SellAccept has no field or method Expiry)
|
run itests postgres:
rfq/stream.go#L149
too many arguments in call to rfqmsg.NewBuyAcceptFromRequest
|
run itests postgres:
rfq/stream.go#L155
too many arguments in call to rfqmsg.NewSellAcceptFromRequest
|
run itests postgres
Process completed with exit code 2.
|
Lint check
too many arguments in call to rfqmsg.NewSellAcceptFromRequest\\n\\thave (rfqmsg.SellRequest, number, uint64)\\n\\twant (rfqmsg.SellRequest, rfqmsg.PriceQuote))\" were hidden, use --max-same-issues"
|
Lint check:
taprpc/marshal.go#L18
could not import github.com/lightninglabs/taproot-assets/rfq (-: # github.com/lightninglabs/taproot-assets/rfq
|
Lint check:
rfq/order.go#L104
quote.Request.AssetAmount undefined (type rfqmsg.BuyRequest has no field or method AssetAmount)
|
Lint check:
rfq/order.go#L105
quote.Expiry undefined (type rfqmsg.BuyAccept has no field or method Expiry)
|
Lint check:
rfq/order.go#L220
quote.Request.AssetAmount undefined (type rfqmsg.SellRequest has no field or method AssetAmount)
|
Lint check:
rfq/order.go#L221
quote.Expiry undefined (type rfqmsg.SellAccept has no field or method Expiry)
|
Lint check:
rfq/stream.go#L149
too many arguments in call to rfqmsg.NewBuyAcceptFromRequest
|
Lint check:
rfq/stream.go#L155
too many arguments in call to rfqmsg.NewSellAcceptFromRequest
|
Lint check:
taprpc/marshal.go#L629
previous case (typecheck)
|
Lint check:
taprpc/marshal.go#L661
previous case (typecheck)
|
run itests:
rfq/order.go#L104
quote.Request.AssetAmount undefined (type rfqmsg.BuyRequest has no field or method AssetAmount)
|
run itests:
rfq/order.go#L105
quote.Expiry undefined (type rfqmsg.BuyAccept has no field or method Expiry)
|
run itests:
rfq/order.go#L220
quote.Request.AssetAmount undefined (type rfqmsg.SellRequest has no field or method AssetAmount)
|
run itests:
rfq/order.go#L221
quote.Expiry undefined (type rfqmsg.SellAccept has no field or method Expiry)
|
run itests:
rfq/stream.go#L149
too many arguments in call to rfqmsg.NewBuyAcceptFromRequest
|
run itests:
rfq/stream.go#L155
too many arguments in call to rfqmsg.NewSellAcceptFromRequest
|
run itests
Process completed with exit code 2.
|
run unit tests (unit-race):
rfqmsg/accept_test.go#L49
unknown field Expiry in struct literal of type BuyAccept
|
run unit tests (unit-race):
rfqmsg/accept_test.go#L51
unknown field InAssetPrice in struct literal of type BuyAccept
|
run unit tests (unit-race):
rfqmsg/accept_test.go#L52
unknown field OutAssetPrice in struct literal of type BuyAccept
|
run unit tests (unit-race):
rfqmsg/accept_test.go#L61
unknown field Expiry in struct literal of type BuyAccept
|
run unit tests (unit-race):
rfqmsg/accept_test.go#L63
unknown field InAssetPrice in struct literal of type BuyAccept
|
run unit tests (unit-race):
rfqmsg/accept_test.go#L64
unknown field OutAssetPrice in struct literal of type BuyAccept
|
run unit tests (unit-race):
rfqmsg/request_test.go#L82
unknown field SuggestedInAssetPrice in struct literal of type BuyRequest
|
run unit tests (unit-race):
rfqmsg/request_test.go#L83
unknown field SuggestedOutAssetPrice in struct literal of type BuyRequest
|
run unit tests (unit-race):
rfqmsg/request_test.go#L98
unknown field SuggestedInAssetPrice in struct literal of type BuyRequest
|
run unit tests (unit-race):
rfqmsg/request_test.go#L99
unknown field SuggestedOutAssetPrice in struct literal of type BuyRequest
|
finish
Error: The process '/home/runner/work/_actions/shogo82148/actions-goveralls/v1/bin/goveralls_linux_amd64' failed with exit code 1
|
Docker build check
buildx failed with: ERROR: failed to solve: process "/bin/sh -c make release-install TAGS=monitoring" did not complete successfully: exit code: 2
|
Sqlc check
Unexpected error: Error: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.
|
Sqlc check
Error: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.
|
Sqlc check
Unexpected error: Error: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.
|
Sqlc check
Unexpected error: Error: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.
|
Sqlc check
Unexpected error: Error: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.
|
Sqlc check
Unexpected error: Error: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.
|
Sqlc check
Unexpected error: Error: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.
|
Sqlc check
Unexpected error: Error: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.
|
Sqlc check
Unexpected error: Error: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.
|
Sqlc check
Unexpected error: Error: Path Validation Error: Path(s) specified in the action for caching do(es) not exist, hence no cache is being saved.
|
migration version check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Compilation check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
test vector check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
cross compilation
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
run unit tests (unit-cover)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
run unit tests (unit dbbackend=postgres)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
run itests postgres
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Lint check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
run itests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Format check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
run unit tests (unit-race)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
go mod check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
RPC check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Docker build check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, docker/setup-qemu-action@v2, docker/setup-buildx-action@v2, docker/build-push-action@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
sample configuration check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Sqlc check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3, jpribyl/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
run LiT tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "logs-itest", "logs-itest-postgres".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
logs-itest
Expired
|
22 Bytes |
|
logs-itest-postgres
Expired
|
22 Bytes |
|