Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staticaddr: loop static listswaps #814

Merged

Conversation

hieblmi
Copy link
Collaborator

@hieblmi hieblmi commented Aug 27, 2024

builds on #786

only the last commit is relevant for this PR

This PR introduces loop static listswaps to enable info look-up of static address loop-in swaps.

Available look-up commands:

loop static listsunspent (looks up lnd wallet utxos for the static address)
loop static summary
loop static listdeposits
loop static listswaps

@hieblmi hieblmi force-pushed the static-addr-swaps-info branch 8 times, most recently from b351145 to 18770ee Compare September 2, 2024 11:42
@hieblmi hieblmi force-pushed the static-addr-swaps-info branch 5 times, most recently from 85ed002 to 23dfa65 Compare September 16, 2024 10:48
@hieblmi hieblmi force-pushed the static-addr-swaps-info branch 3 times, most recently from 8f153d7 to b88116e Compare September 19, 2024 09:08
@hieblmi hieblmi mentioned this pull request Sep 19, 2024
6 tasks
@hieblmi hieblmi force-pushed the static-addr-swaps-info branch 3 times, most recently from 0518411 to b1e91f6 Compare September 26, 2024 10:14
@hieblmi hieblmi force-pushed the static-addr-swaps-info branch 3 times, most recently from 0e91d5e to d4cbb87 Compare October 24, 2024 12:17
@hieblmi hieblmi force-pushed the static-addr-swaps-info branch 10 times, most recently from 8fb1de8 to 111f8ef Compare October 31, 2024 13:10
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New commit LGTM 🎉

func (s *swapClientServer) GetStaticAddressSummary(ctx context.Context,
req *looprpc.StaticAddressSummaryRequest) (
*looprpc.StaticAddressSummaryResponse, error) {
func (s *swapClientServer) ListStaticAddressDeposits(ctx context.Context,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing godoc

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

}, nil
}

func (s *swapClientServer) ListStaticAddressSwaps(ctx context.Context,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing godoc

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@bhandras bhandras self-requested a review November 4, 2024 14:40
@hieblmi hieblmi force-pushed the static-addr-swaps-info branch 2 times, most recently from bb4ff64 to aa2fb86 Compare November 5, 2024 09:53
Copy link
Member

@sputn1ck sputn1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@hieblmi hieblmi merged commit 6e62d3b into lightninglabs:static-addr-staging Nov 5, 2024
4 checks passed
@hieblmi hieblmi deleted the static-addr-swaps-info branch November 5, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants