Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update lnd to v0.17.0-beta #30

Merged
merged 1 commit into from
Oct 30, 2023
Merged

deps: update lnd to v0.17.0-beta #30

merged 1 commit into from
Oct 30, 2023

Conversation

jbrill
Copy link
Contributor

@jbrill jbrill commented Oct 25, 2023

Updates the lnd bindings to reflect v0.17.0-beta

@jbrill jbrill requested a review from jamaljsr October 25, 2023 18:53
Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind also updating loop and tapd to the versions supported by LNC? It makes sense to update all of them at once.

The LNC wasm-client go.mod file contains the specific versions that are compatible.

@jbrill
Copy link
Contributor Author

jbrill commented Oct 26, 2023

@jamaljsr thanks for the help! Was able to update the versions. I noticed the pool version seemed to be a bit inconsistent v0.6.4-beta.0.20231003174306-80d8854a0c4b, which was incompatible with the yarn generate command. I simply use v0.6.4-beta in this PR.

Copy link
Collaborator

@ViktorTigerstrom ViktorTigerstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🔥!
Though I'd like to stress that I have never coded Typescript, and have very little web programming experience in general, so I don't know if you should depend on my review too heavily heh 😅! So please give @jamaljsr review much more weight.

I noticed the pool version seemed to be a bit inconsistent v0.6.4-beta.0.20231003174306-80d8854a0c4b, which was incompatible with the yarn generate command. I simply use v0.6.4-beta in this PR.

I'd like to comment regarding this though, as that the plain pool v0.6.4-beta version does not include lnd version v0.17.0-beta. The inconsistent version is a version that Oli created that just adds lnd v0.17.0-beta to that release, until the next release is out. This is the version that we have added in LiT + LNC, so I think it would make sense to use the same version in LNC-core? Else when adding the new version of LNC, it'll require that dependency anyways? I also don't know if we get any unwanted side effects in LNC-core if we add a pool version that doesn't have lnd v0.17.0-beta, but then bump the lnd version that's used in LNC-core to v0.17.0-beta.

Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 👌

@jamaljsr jamaljsr merged commit d0bc2ae into main Oct 30, 2023
3 checks passed
@jamaljsr jamaljsr deleted the bump-lnd-v17 branch October 30, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants