Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump google-protobuf dep #850

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

build: bump google-protobuf dep #850

wants to merge 2 commits into from

Conversation

djkazic
Copy link

@djkazic djkazic commented Sep 22, 2024

Today, the presence of a channel with peer_scid_alias on (more accurately, if it has entries for alias_scids) will cause a binary deserialization fail with the error:

t.isDelimited is not a function
  at Object.readMessage
  at Function.deserializeBinaryFromReader
  at Function.deserializeBinary
  at Array.forEach
  at e.onTransportChunk

This happens inside grpc-web, but it's due to an outdated google-protobuf dependency. This PR upgrades it.

ellemouton
ellemouton approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellemouton ellemouton ellemouton approved these changes

@jamaljsr jamaljsr Awaiting requested review from jamaljsr

@ViktorTigerstrom ViktorTigerstrom Awaiting requested review from ViktorTigerstrom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djkazic @ellemouton