build: convert litrpc into a module #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhandras
force-pushed
the
litrpc-module
branch
from
e83cf65
to
7d2e962
Compare
1 task
bhandras
force-pushed
the
litrpc-module
branch
from
7d2e962
to
c648dd8
Compare
bhandras
force-pushed
the
litrpc-module
branch
from
c648dd8
to
b7fd53d
Compare
guggero
approved these changes
Oct 14, 2024
|
|
||
| // We want to format raw bytes as hex instead of base64. The forked version | ||
| // allows us to specify that as an option. | ||
| replace google.golang.org/protobuf => github.com/lightninglabs/protobuf-go-hex-display v1.34.2-hex-display |
There was a problem hiding this comment.
We don't make any references to the UseHexForBytes change in the library here and replace directives aren't transitive. So we might as well remove this if we wanted to (if you prefer to leave it in for completeness' sake, just ignore this comment).
There was a problem hiding this comment.
Unfortunately it does not compile without the replace.
There was a problem hiding this comment.
Aaah, because another RPC module (loop/pool/faraday) uses it. Okay, never mind then.
ellemouton
approved these changes
Oct 14, 2024
| @@ -21,4 +23,6 @@ | |||
|
|
|||
| # Contributors (Alphabetical Order) | |||
|
|
|||
| * Andras Banki-Horvath | |||
|
|
|||
There was a problem hiding this comment.
(dont worry - i'll fix it in an open PR i have)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #821
Depends on: