Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui+auth: updates login page view #553

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ui+auth: updates login page view #553

wants to merge 2 commits into from

Conversation

dstrukt
Copy link
Contributor

@dstrukt dstrukt commented May 17, 2023

Not sure why the test is failing, I've removed that snippet of code in the test..

Current:
Screen Shot 2023-05-16 at 6 10 39 PM

Proposed:
Screen Shot 2023-05-17 at 9 49 44 AM
Screen Shot 2023-05-17 at 9 49 52 AM
Screen Shot 2023-05-17 at 9 50 02 AM

@dstrukt dstrukt self-assigned this May 17, 2023
@dstrukt dstrukt force-pushed the lit-auth-update branch 6 times, most recently from aec8586 to 22858ef Compare May 17, 2023 17:36
@dstrukt dstrukt marked this pull request as ready for review May 17, 2023 18:01
Copy link
Contributor

@itsrachelfish itsrachelfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dstrukt Is the sidebar supposed to look like this? 😅 It doesn't seem to match the color scheme of the background.

Screenshot from 2023-08-16 00-22-25

Additionally, I noticed that the background gradient only fills 1 viewport height. When the page is longer than the screen and you scroll down, the background color changes

Screenshot from 2023-08-16 00-23-52

@lightninglabs-deploy
Copy link

@jbrill: review reminder
@dstrukt, remember to re-request review from reviewers when ready

@lightninglabs-deploy
Copy link

Closing due to inactivity

8 similar comments
@lightninglabs-deploy
Copy link

Closing due to inactivity

@lightninglabs-deploy
Copy link

Closing due to inactivity

@lightninglabs-deploy
Copy link

Closing due to inactivity

@lightninglabs-deploy
Copy link

Closing due to inactivity

@lightninglabs-deploy
Copy link

Closing due to inactivity

@lightninglabs-deploy
Copy link

Closing due to inactivity

@lightninglabs-deploy
Copy link

Closing due to inactivity

@lightninglabs-deploy
Copy link

Closing due to inactivity

@guggero
Copy link
Member

guggero commented Feb 12, 2024

!lightninglabs-deploy mute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants