Add version labels to the UI #440
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a few issues (#203, #421, #421) involving version numbers in the UI so I started to look into it to see what might be involved
I was able to get something basic rendered in the sidebar because
lnd.getInfojust happened to return the version number already...however it gets trickier from here
I don't think it's exactly as easy to do for the LiT version number since the
app/src/api/lit.tsonly haslitcli sessionGRPC calls implemented so far. But obviouslylitcli --vreturns the version so maybe that approach could work...I stopped there since it started to get quite involved but will try to chip away at this and see if it can be done.
Also wanted to see if there is a different approach anyone might recommend.. or if there is any design / code style feedback on the implemented LND version in 223ca0c