Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump transaction event handler fixups #2393

Merged
merged 6 commits into from
Jul 12, 2023
Merged

Bump transaction event handler fixups #2393

merged 6 commits into from
Jul 12, 2023

Commits on Jul 11, 2023

  1. Accept BumpTransactionEvent in handle_event 

    There's no reason to accept the general `Event` enum.
    @wpaulino
    wpaulino committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    a100ed0 View commit details
    Browse the repository at this point in the history

  2. Expose CoinSelection struct members 

    These are meant to be provided by the user, so they need to be exposed
in the API.
    @wpaulino
    wpaulino committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    ae701a0 View commit details
    Browse the repository at this point in the history

  3. Cache HTLC per_commitment_point in descriptor 

    This allows us to obtain the HTLC input and output from its descriptor
without needing to derive the `per_commitment_point` through the signer.
    @wpaulino
    wpaulino committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    72c42ee View commit details
    Browse the repository at this point in the history

  4. Provide missing post-derivation signer parameters 

    Users may expect these to be provided manually after derivation in the
event they need to perform any enforcement prior to signing.
    @wpaulino
    wpaulino committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    690ad18 View commit details
    Browse the repository at this point in the history

  5. Add transaction-related helpers to AnchorDescriptor 

    This provides a similar interface as `HTLCDescriptor` for users which
choose to implement their own bump transaction event handler.
    @wpaulino
    wpaulino committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    0dbfe24 View commit details
    Browse the repository at this point in the history

  6. Expose previous UTXO for anchor and HTLC inputs 

    This may be required by some wallets that rely on PSBTs internally to
create/sign transactions.
    @wpaulino
    wpaulino committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    4c7883c View commit details
    Browse the repository at this point in the history