f Avoid superfluous collect

lightningdevkit · Feb 2, 2024 · 2de3f2c · 2de3f2c
1 parent 735b89f
commit 2de3f2c
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/lightning/src/util/sweep.rs b/lightning/src/util/sweep.rs
@@ -318,16 +318,14 @@ where
 		&self, mut output_descriptors: Vec<SpendableOutputDescriptor>,
 		channel_id: Option<ChannelId>, exclude_static_ouputs: bool,
 	) {
-		let relevant_descriptors = if exclude_static_ouputs {
-			output_descriptors
-				.drain(..)
-				.filter(|desc| !matches!(desc, SpendableOutputDescriptor::StaticOutput { .. }))
-				.collect::<Vec<_>>()
-		} else {
-			output_descriptors
-		};
-
-		if relevant_descriptors.is_empty() {
+		let mut relevant_descriptors = output_descriptors
+			.drain(..)
+			.filter(|desc| {
+				!(exclude_static_ouputs &&
+				matches!(desc, SpendableOutputDescriptor::StaticOutput { .. }))
+			}).peekable();
+
+		if relevant_descriptors.peek().is_none() {
 			return;
 		}