Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SendingParameters struct for customizable payments #336

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Add SendingParameters struct for customizable payments #336

merged 5 commits into from
Aug 27, 2024

Commits on Aug 27, 2024

  1. Introduce SendingParameters struct 

    `SendingParameters` allows users to override opinionated values while
routing a payment such as `max_total_routing_fees`, `max_path_count`
`max_total_cltv_delta`, and `max_channel_saturation_power_of_half`

Updated docs for `max_channel_saturation_power_of_half` for
clarity.
    @slanesuke
    slanesuke committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    5fe90d1 View commit details
    Browse the repository at this point in the history

  2. Add default SendingParameters to node config 

    Introduced `sending_parameters_config` to `Config` for node-wide
routing and pathfinding configuration. Also, added default values
for `SendingParameters` to ensure reasonable defaults when no
custom settings are provided by the user.
    @slanesuke
    slanesuke committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    bf4ddff View commit details
    Browse the repository at this point in the history

  3. Add SendingParameters to bolt11 send 

    Updated `Bolt11Payment` `send` method to accept `SendingParameters`,
as a parameter. If the user provided sending params the default
values are overridden.
    @slanesuke
    slanesuke committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    d6e6ff7 View commit details
    Browse the repository at this point in the history

  4. Add SendingParameters to bolt11 send_using_amount 

    Added the optional `SendingParameters` to `send_using_amount` in
`Bolt11Payment`. If the user provides sending params the values
will be overridden otherwise they'll use the default values.
    @slanesuke
    slanesuke committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    2b85ba9 View commit details
    Browse the repository at this point in the history

  5. Add SendingParameters to spontaneous send 

    Added optional SendingParameters to the send method in
SpontaneousPayment. If the user provides sending params
the values will be overridden otherwise they remain the
same.
    @slanesuke
    slanesuke committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    4822336 View commit details
    Browse the repository at this point in the history