Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RetryPolicy to VssClient #226

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Add RetryPolicy to VssClient #226

merged 1 commit into from
Jan 15, 2024

Conversation

G8XSU
Copy link
Contributor

@G8XSU G8XSU commented Jan 8, 2024 •
edited
Loading

  • Add RetryPolicy to VssClient

@G8XSU G8XSU requested a review from tnull January 8, 2024 20:52
@G8XSU
Copy link
Contributor Author

G8XSU commented Jan 8, 2024

Depends on lightningdevkit/vss-rust-client#23
But can be independently reviewed.

tnull
tnull reviewed Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good from a first pass. Will do another one once the upstream PR lands.

src/io/vss_store.rs Outdated Show resolved Hide resolved
src/io/vss_store.rs Show resolved Hide resolved
src/io/vss_store.rs Outdated Show resolved Hide resolved
@G8XSU
Copy link
Contributor Author

G8XSU commented Jan 11, 2024

Dependent PR is now merged.
Will do a force-push here so that CI builds with vss-client v0.2.

@G8XSU G8XSU requested a review from tnull January 12, 2024 00:41
tnull
tnull approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We still have to figure out how to handle cases where persistence would fail and we can't bubble up an error to the user (e.g., in event handling).

@tnull tnull merged commit e6b0c0f into lightningdevkit:main Jan 15, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnull tnull tnull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@G8XSU @tnull