Remove uniform wrapper and use concise setUniform<1f,2f,3f,4f> methods #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the setUniform methods in the WebGLContextWrapper class to use the individual WebGL uniform setter functions instead of the generic `gl.uniform` function. This change improves code readability and ensures that the correct uniform setter is used for each type of uniform variable.
- Removed the setUniform method from the WebGLContextWrapper class. - Updated the setUniform method to handle different types of uniforms, including single argument uniforms like uniform1f, uniform1fv, etc. - Added support for setting uniform values using the appropriate WebGLRenderingContext methods based on the uniform type. Related to #374
elsassph
reviewed
Sep 13, 2024
jfboeve
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #374
Could not fall back to
argumentsas that isn't allowed in strict mode, working around that only made it worse.Moved everything up early in the chain to call the respective uniform method directly, with minimal overhead which should avoid the additional GC pressure as described in #374
Only thing I need to figure out what the impact is of losing the
setUniformargument caching that was originally there, worst case we have to implement a cache check at each individual uniform method.@jfboeve the Dynamic Shader was a bit of a thing - please 👀 if this makes sense. I don't know if the additional argument uniforms can actually happen in the Dynamic Shader case (I assumed so).