Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add go bindings #3

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Add go bindings #3

merged 6 commits into from
Jan 23, 2024

Conversation

Sledro
Copy link
Member

@Sledro Sledro commented Jan 22, 2024

  • adds go bindings package and update latest bindings
  • makes defendDataRootInclusion() payable
  • fix compiler warning / unused var in defendDataRootInclusion()

@CryptoKass CryptoKass self-requested a review January 23, 2024 04:02
CryptoKass
CryptoKass reviewed Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@CryptoKass CryptoKass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

However, gobind doesn't seem to work with certain node versions, include node 20.x.x LTS versions. See issue dl-solarity/hardhat-gobind#11 and dl-solarity/hardhat-gobind#14

It does work with node 18, so will specify that version for now.

@CryptoKass CryptoKass merged commit a6f937b into main Jan 23, 2024
@CryptoKass CryptoKass deleted the add-go-bindings branch January 23, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CryptoKass CryptoKass CryptoKass left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sledro @CryptoKass