-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bazel CI #295
Bazel CI #295
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #295 +/- ##
===========================================
+ Coverage 73.09% 83.47% +10.38%
===========================================
Files 174 127 -47
Lines 22815 14703 -8112
===========================================
- Hits 16676 12273 -4403
+ Misses 6139 2430 -3709
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@hansl I'm not 100% finished |
.circleci/config.yml
Outdated
- run: | ||
name: installing bazelisk | ||
command: | | ||
wget https://github.com/bazelbuild/bazelisk/releases/download/v1.15.0/bazelisk-linux-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to check the SHA?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SHAs are currently unavailable from the Bazelisk GitHub release page. I asked on their Slack.
- run: | ||
name: installing bazelisk | ||
command: | | ||
curl -L -O https://github.com/bazelbuild/bazelisk/releases/download/v1.16.0/bazelisk-darwin-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above. Also I can't remember but I think brew is installed on those machines, so just brew install bazelisk
could do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It takes forever to run brew
on the CI (I stopped it after 2mins) vs fetching the binary (2s).
Let's stick to the current method.
Co-authored-by: Hans Larsen <[email protected]> Signed-off-by: Félix C. Morency <[email protected]>
Co-authored-by: Hans Larsen <[email protected]> Signed-off-by: Félix C. Morency <[email protected]>
Co-authored-by: Hans Larsen <[email protected]> Signed-off-by: Félix C. Morency <[email protected]>
xlarge
Linux Docker executor in CI for everything except Docker-related stepsFixes #294
Fixes #264
Fixes #265
TODO:
macos
(building works, I need a system to test it on!)