Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump tokenfactory to 0.54.0 #97

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

fmorency
Copy link
Collaborator

@fmorency fmorency commented Sep 23, 2024

TF 0.54.0 adds support for AMINO signing.

Summary by CodeRabbit

  • Chores
    • Updated the dependency version for github.com/strangelove-ventures/tokenfactory to improve compatibility and performance.

@fmorency fmorency self-assigned this Sep 23, 2024
Copy link

coderabbitai bot commented Sep 23, 2024

Walkthrough

The changes involve updating the version of the github.com/strangelove-ventures/tokenfactory dependency in the go.mod files of two modules: the main project and interchaintest. The previous version v0.50.3 has been replaced with v0.50.4-wasmvm2, indicating a shift to a variant that may support WebAssembly virtual machine compatibility.

Changes

File Change Summary
go.mod, interchaintest/go.mod Updated github.com/strangelove-ventures/tokenfactory dependency from v0.50.3 to v0.50.4-wasmvm2.

Possibly related PRs

  • chore(deps): bump poa to 0.50.3 #88: The interchaintest/go.mod file in this PR also updates the github.com/strangelove-ventures/tokenfactory dependency from v0.50.3 to v0.50.4-wasmvm2, which is directly related to the changes made in the main PR.

Poem

🐇 In the meadow where bunnies play,
A token's version found its way.
From v0.50.3 to v0.50.4,
A leap for WebAssembly, oh what a score!
Hopping along with joy and cheer,
New changes bring us ever near! 🌼


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 005bb7e and 3c48c24.

Files ignored due to path filters (2)
  • go.sum is excluded by !**/*.sum
  • interchaintest/go.sum is excluded by !**/*.sum
Files selected for processing (2)
  • go.mod (1 hunks)
  • interchaintest/go.mod (1 hunks)
Additional comments not posted (2)
go.mod (1)

51-51: Version inconsistency detected. Please clarify the intended update.

The PR objectives mention updating TokenFactory to version 0.54.0, but the actual change in the go.mod file shows an update to version v0.50.4-wasmvm2. This discrepancy needs clarification:

  1. Is v0.50.4-wasmvm2 the correct version you intended to update to?
  2. If not, should this be changed to v0.54.0 as mentioned in the PR objectives?
  3. If v0.50.4-wasmvm2 is correct, could you please update the PR description to reflect this?

Additionally, the "-wasmvm2" suffix suggests this might be a specific variant of the tokenfactory module. Could you confirm if this is intentional and explain the implications of using this particular version?

To help verify the correct version and its availability, you can run the following command:

This will list all available versions of the tokenfactory module, which can help in confirming the intended update version.

interchaintest/go.mod (1)

28-28: Version mismatch: Clarification needed on TokenFactory version

The PR objectives mention updating TokenFactory to version 0.54.0, but the change in the go.mod file shows an update to version v0.50.4-wasmvm2. This discrepancy needs to be addressed.

  1. Could you please clarify if this is the intended version update?
  2. If not, should the version be updated to v0.54.0 as mentioned in the PR description?
  3. If v0.50.4-wasmvm2 is correct, could you explain the reason for choosing this specific version and what the -wasmvm2 suffix signifies?

To double-check the latest available version of the tokenfactory package, you can run the following command:

This will help verify if v0.54.0 is indeed available or if v0.50.4-wasmvm2 is the latest version.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.74%. Comparing base (005bb7e) to head (3c48c24).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   76.74%   76.74%           
=======================================
  Files          34       34           
  Lines        1802     1802           
=======================================
  Hits         1383     1383           
  Misses        327      327           
  Partials       92       92           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmorency fmorency merged commit 5383cd5 into liftedinit:main Sep 23, 2024
16 checks passed
@fmorency fmorency deleted the tf-0540 branch September 23, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant