Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: more tests and cleanup #69

Merged
merged 12 commits into from
Jun 5, 2024
Merged

Conversation

fmorency
Copy link
Collaborator

@fmorency fmorency commented Jun 4, 2024

This PR adds

  • Additional keeper unit tests
  • Check error content in tests
  • Code cleanup (value vs pointer receiver mix, comments, lint)
  • bump go to 1.22.4 (security fixes)
  • bump alpine to 3.20 otherwise heighliner fails

@fmorency fmorency self-assigned this Jun 4, 2024
@fmorency fmorency changed the title test: more tests test: more tests and cleanup Jun 4, 2024
@fmorency
Copy link
Collaborator Author

fmorency commented Jun 4, 2024

I'll rerun the failed job tomorrow as we reached Docker request limits.

toomanyrequests: You have reached your pull rate limit.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.

Project coverage is 74.32%. Comparing base (5785a35) to head (32d5026).

Files Patch % Lines
x/manifest/types/msgs.go 0.00% 6 Missing ⚠️
x/manifest/module.go 63.63% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   73.41%   74.32%   +0.91%     
==========================================
  Files          31       31              
  Lines        1685     1675      -10     
==========================================
+ Hits         1237     1245       +8     
+ Misses        395      377      -18     
  Partials       53       53              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmorency fmorency marked this pull request as ready for review June 5, 2024 13:29
@fmorency fmorency requested a review from Reecepbcups June 5, 2024 13:31
@fmorency
Copy link
Collaborator Author

fmorency commented Jun 5, 2024

Disregard the codecov/patch complain.

Dockerfile Show resolved Hide resolved
x/manifest/depinject.go Outdated Show resolved Hide resolved
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/cosmos/cosmos-sdk/types/msgservice"
)

var amino = codec.NewLegacyAmino()

func init() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember removing this in the past for a network & it causing issues. They did come up from SDK v47 -> v50 though, so it's possible it was specific to that vs being on SDK v50 from the start like manifest. Just want to call it out now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you remember the issue?

@fmorency fmorency merged commit 1aff27e into liftedinit:main Jun 5, 2024
14 of 15 checks passed
@fmorency fmorency deleted the moar-tests branch June 5, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants